This repository has been archived by the owner on Jul 14, 2022. It is now read-only.
Proposal: Makefile and setting version by tag #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Woah, that was quite fast. Thanks for this I'd suggest to update the Other than that.... LGTM 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a short
Makefilethat makes it a bit easier for someone to quickly build/install/update usingmake. The version is set incli.goduring buildtime to the highest version tag by building this way.When I added the
makeinstructions toREADME.mdit appears VSCode autoformatted, so apologies for the whitespace. But, I figured it was harmless.I don't know if this is a change you would want, but I figured why not propose it? If you do want this, feel free to merge it. And if not, feel free to close the PR instead (I won't be offended).