Skip to content
This repository has been archived by the owner on Jul 14, 2022. It is now read-only.

Revise Help message 🍣 #20

Merged
merged 2 commits into from
Oct 8, 2020
Merged

Revise Help message 🍣 #20

merged 2 commits into from
Oct 8, 2020
+6 −6

Conversation

shtakai
Copy link
Contributor

@shtakai shtakai commented Oct 7, 2020 •
edited
Loading

Why?

  • On viewing help option or without options, there is an unnecessary S on help message.

Screen Shot 2020-10-07 at 15 07 09

How?

  • Just removed S. 🍣
  • Change Postwoman to Hoppscotch on the help message

❤️
Screen Shot 2020-10-07 at 17 02 06

@shtakai shtakai changed the title Remove unnecessary S on help :sushi Remove unnecessary S on help 🍣 Oct 7, 2020
@athul
Copy link
Contributor

athul commented Oct 7, 2020 •
edited
Loading

Hey could you also rename POSTWOMAN CLI To Hoppscotch CLI and PostWoman team to HoppScotch team in The help text?

Thanks

@shtakai
Copy link
Contributor Author

shtakai commented Oct 7, 2020

OOhh.. I'll change and rename PR's title. :)

@shtakai shtakai changed the title Remove unnecessary S on help 🍣 Revise Help message 🍣 Oct 7, 2020
athul
athul approved these changes Oct 7, 2020
View reviewed changes
Copy link
Contributor

@athul athul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks @shtakai

@athul athul requested a review from liyasthomas October 7, 2020 08:03
@athul athul merged commit a064870 into hoppscotch:master Oct 8, 2020
@shtakai shtakai deleted the chore/remove-S-on-help branch October 12, 2020 02:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@athul athul athul approved these changes

@liyasthomas liyasthomas Awaiting requested review from liyasthomas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shtakai @athul