Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE Support #425

Closed
wants to merge 13 commits into from
Closed

IE Support #425

wants to merge 13 commits into from

Conversation

AndrewBastin
Copy link
Member

@AndrewBastin AndrewBastin commented Dec 13, 2019

NOTE : This is a draft PR, implementation hasn't reached a stable standard, the PR is opened as a notification of ongoing work, as a place to discuss, and as an invitation to help make this feature stable

This PR intends to introduce IE (11) support to Postwoman.

Implemented So Far

Basic IE functionality

IE functionality is implemented by transpiling the generated Nuxt JS scripts into IE11 compatible ES5 code using Babel. This transpilation can be done by running the newly added command npm run build-ie. The generated dist folder will be IE compatible (to the extent that is implemented).

The site runs (with styling issues) on IE. Basic functionality (running REST, WebSocket and GraphQL requests) work without any issues (as far as I have tested, which isn't a lot). Missing modern JS features are patched into the site using polyfills from polyfill.io.

What's left to be done

  • Well, the styles are pretty broken, pretty sure its due the SCSS stuff and modern CSS features we use like media queries and CSS variables (added polyfill for variables in 0ac9772).
  • Thorough testing has to be done to check whether we missed something in IE or if we broke something in the other browsers.
  • Improve the build script ? (@jamesgeorge007, this might be something right up your ballpark)

We would love your help for implementing making this feature possible.

Happy Hacking!!!! 👨‍💻 👩‍💻 ❤️

This PR fixes #386

@AndrewBastin AndrewBastin added help wanted Extra attention is needed core Changes regarding core concepts critical Better handle this first labels Dec 13, 2019
@AndrewBastin AndrewBastin added this to the v2.0 milestone Dec 13, 2019
@ghost
Copy link

ghost commented Dec 13, 2019

DeepCode Report (#51fd95)

DeepCode analyzed this pull request.
There are 5 new info reports.

@TravisBuddy
Copy link

Hey @AndrewBastin,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: daba2220-1d42-11ea-a2fb-51cb67500490

@TravisBuddy
Copy link

Hey @AndrewBastin,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 0a2a0e30-1d57-11ea-a2fb-51cb67500490

@TravisBuddy
Copy link

Hey @AndrewBastin,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 549adde0-1dd0-11ea-a424-4f8e788bb22e

@TravisBuddy
Copy link

Hey @AndrewBastin,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: bead6f40-1f0b-11ea-8c7c-334558e6cc20

@TravisBuddy
Copy link

Hey @AndrewBastin,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 8bd12240-1fb2-11ea-ba47-7f442aed9c1e

@AndrewBastin
Copy link
Member Author

Closing this PR, as IE Support is no longer a main priority and it is seemingly really difficult to make a non-comprimising implementation.

Focus is shifted to the browser extension approach for native-like implementations.

@liyasthomas liyasthomas deleted the feature/ie-support branch February 13, 2020 10:03
@liyasthomas liyasthomas restored the feature/ie-support branch February 13, 2020 10:03
@liyasthomas liyasthomas deleted the feature/ie-support branch May 12, 2020 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Changes regarding core concepts critical Better handle this first help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IE Support
3 participants