GraphQL page improvements, and more #602

dihmeetree · 2020-02-25T04:38:25Z

This PR does the following:

Saves the schema and response to the local state, so if you refresh or navigate to a new page and back, it will show up again. 21c6c07
Update the Run Query button so it matches the Get schema button
Running a query now shows "Loading..." in the response section, similar to when you click "Get Schema" ab49a12
Saves collapsed sections to the local state, similarly to the schema and response, Postwoman will show sections collapsed if you refresh/navigate away. (This will work on all pages; Not just the GraphQL page, as it uses the route as a key) 2d5b70a
Fixes auto scroll toggle (While I don't necessarily agree with how settings are initialized in the store; I've added checks for undefined auto scroll keys) 6d534d3
(Fix) Set showExtensionsToast to false in localStorage when no is clicked on the extensions toast 1d616c7
Disable spell check on input fields (Shows red line under text if spell check is enabled)
(Fix) Error message for failed queries/mutations on GraphQL page
(Fix) Disable json linting for response editor on GraphQL page JSON linting in the code editor #605 (comment)
Moved .prettierrc and .huskyrc contents to the package.json file, so we have 2 less files to manage 50339a2

Note: I haven't gotten around to saving the types/queries/mutation to the local state yet (the Docs) But I will get to that soon :)

Allows the user to go to the settings page, and back to the GraphQL page, without having to re-request the schema or response.

When you refresh or navigate to a new page and back, your collapsed sections will be as you set them.

ghost · 2020-02-25T04:38:37Z

DeepCode's analysis on #50339a found:

❌ 0 critical issues. ⚠️ 0 warnings and 1 minor issue. ✔️ 0 issues were fixed.

💬 This comment has been generated by the DeepCode bot, installed by the owner of the repository. The DeepCode bot protects your repository by detecting and commenting on security vulnerabilities or other critical issues.

☺️ If you want to provide feedback on our bot, here is how to contact us.

TravisBuddy · 2020-02-25T05:08:27Z

Hey @dmitryyankowski,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: d9c11890-578c-11ea-b14f-b186f6b55800

TravisBuddy · 2020-02-25T05:20:04Z

Hey @dmitryyankowski,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 79380b30-578e-11ea-b14f-b186f6b55800

Wasn't actually working with the last PR. This one fixes it.

TravisBuddy · 2020-02-25T05:52:41Z

Hey @dmitryyankowski,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 07c87c50-5793-11ea-b14f-b186f6b55800

TravisBuddy · 2020-02-25T06:20:07Z

Hey @dmitryyankowski,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: dcef4280-5796-11ea-acab-ef795e2c3319

TravisBuddy · 2020-02-25T06:23:57Z

Hey @dmitryyankowski,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 65de5810-5797-11ea-acab-ef795e2c3319

TravisBuddy · 2020-02-25T06:56:12Z

Hey @dmitryyankowski,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: e7a81080-579b-11ea-acab-ef795e2c3319

TravisBuddy · 2020-02-25T07:24:56Z

Hey @dmitryyankowski,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: eb5a6d50-579f-11ea-acab-ef795e2c3319

liyasthomas · 2020-02-25T15:22:35Z

@dmitryyankowski pre-commit hooks have been introduced hence please rebase to current master and pull latest change, then send PR.

Allows the user to go to the settings page, and back to the GraphQL page, without having to re-request the schema or response.

When you refresh or navigate to a new page and back, your collapsed sections will be as you set them.

Wasn't actually working with the last PR. This one fixes it.

dihmeetree · 2020-02-26T02:04:47Z

@liyasthomas can we address the build issue, before I push any more changes? Getting CypressError: Timed out retrying: expected '<div#response-details-wrapper>' to contain 'FAKE Cat API' again in the build step. 😭

TravisBuddy · 2020-02-26T02:06:30Z

Hey @dmitryyankowski,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 99ab8be0-583c-11ea-b533-891a36a4ac0b

liyasthomas · 2020-02-26T02:07:32Z

@dmitryyankowski I don't know exactly what's wrong with the CI, locally everything seems to be working fine.

dihmeetree · 2020-02-26T02:09:30Z

@dmitryyankowski I don't know exactly what's wrong with the CI, locally everything seems to be working fine.

Yeah it always works fine locally for me too. It does something weird in Travis CI, and times out for some reason 😭

liyasthomas · 2020-02-26T02:12:31Z

Lemme bump dependencies and see whether is there any issue with the Cypress itself. Sorry for the inconveniences.

Was setting the response to an empty string. But this makes it show the correct error.

TravisBuddy · 2020-02-26T02:31:04Z

Hey @dmitryyankowski,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 081470d0-5840-11ea-b533-891a36a4ac0b

Should stick to semantic code here.. rather than doing the shorthand way

dihmeetree · 2020-02-26T02:39:58Z

@AndrewBastin can you review this PR, when you have the time? Thank you!

TravisBuddy · 2020-02-26T02:52:03Z

Hey @dmitryyankowski,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: f633fef0-5842-11ea-b533-891a36a4ac0b

TravisBuddy · 2020-02-26T02:59:52Z

Hey @dmitryyankowski,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 0d758f10-5844-11ea-b533-891a36a4ac0b

TravisBuddy · 2020-02-26T04:01:54Z

Hey @dmitryyankowski,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: b84611a0-584c-11ea-b533-891a36a4ac0b

TravisBuddy · 2020-02-26T04:14:13Z

Hey @dmitryyankowski,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 7037f430-584e-11ea-b533-891a36a4ac0b

dihmeetree added 3 commits February 24, 2020 16:12

Save GraphQL schema and response in state

21c6c07

Allows the user to go to the settings page, and back to the GraphQL page, without having to re-request the schema or response.

Change from v-model to value as this is not set by the user

403254a

Save collapsed sections to state

a3d6573

When you refresh or navigate to a new page and back, your collapsed sections will be as you set them.

Merge branch 'master' into feature/fix-gql-state

e233e9b

dihmeetree requested review from liyasthomas, AndrewBastin, NBTX and jamesgeorge007 February 25, 2020 04:41

Add loading message in response box for "Run query" action

7c23cd7

dihmeetree changed the title ~~Feature: WIP - Improve GraphQL page state~~ WIP: Improve GraphQL page state Feb 25, 2020

dihmeetree changed the title ~~WIP: Improve GraphQL page state~~ WIP: Improve GraphQL page state, and more Feb 25, 2020

Fix auto scroll

62a970e

Wasn't actually working with the last PR. This one fixes it.

dihmeetree added 2 commits February 25, 2020 00:59

Set showExtensionsToast to false in local storage if no is clicked

0eab54c

Fix: Set showExtensionsToast to false in local storage if no is clicked

1d616c7

Disable spell check on input fields

90d347d

Re-trigger build

b8ba6e3

dihmeetree added 5 commits February 25, 2020 10:55

Save GraphQL schema and response in state

5779cdd

Allows the user to go to the settings page, and back to the GraphQL page, without having to re-request the schema or response.

Change from v-model to value as this is not set by the user

6b675d5

Save collapsed sections to state

2d5b70a

When you refresh or navigate to a new page and back, your collapsed sections will be as you set them.

Add loading message in response box for "Run query" action

ab49a12

Fix auto scroll

6d534d3

Wasn't actually working with the last PR. This one fixes it.

dihmeetree dismissed liyasthomas’s stale review via f4b4676 February 26, 2020 01:45

dihmeetree added 2 commits February 25, 2020 20:48

Remove unnecessary variable

5904036

Remove shouldLint variable

8d7c6f4

dihmeetree added feature New feature or request and removed do not merge This will break everything labels Feb 26, 2020

hoppscotch deleted a comment from TravisBuddy Feb 26, 2020

Set response to proper error message

60f2482

Was setting the response to an empty string. But this makes it show the correct error.

liyasthomas mentioned this pull request Feb 26, 2020

Feature: Add prettier/pretty-quick formatting w/ Husky pre-commit #596

Merged

Switch to semantic if checks

f36b91c

Should stick to semantic code here.. rather than doing the shorthand way

dihmeetree requested a review from liyasthomas February 26, 2020 02:40

dihmeetree added 3 commits February 25, 2020 22:40

Re-trigger build

2802e04

Re-trigger build

dddd8f3

Moved both prettier config and husky config into package.json

50339a2

dihmeetree changed the title ~~Improve GraphQL page state, and more~~ GraphQL page improvements, and more Feb 26, 2020

liyasthomas approved these changes Feb 26, 2020

View reviewed changes

liyasthomas merged commit 21e9959 into hoppscotch:master Feb 26, 2020

liyasthomas removed the request for review from AndrewBastin February 26, 2020 06:43

dihmeetree deleted the feature/fix-gql-state branch February 26, 2020 21:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GraphQL page improvements, and more #602

GraphQL page improvements, and more #602

dihmeetree commented Feb 25, 2020 •

edited

Loading

ghost commented Feb 25, 2020 •

edited by ghost

Loading

TravisBuddy commented Feb 25, 2020

TravisBuddy commented Feb 25, 2020

TravisBuddy commented Feb 25, 2020

TravisBuddy commented Feb 25, 2020

TravisBuddy commented Feb 25, 2020

TravisBuddy commented Feb 25, 2020

TravisBuddy commented Feb 25, 2020

liyasthomas commented Feb 25, 2020

dihmeetree commented Feb 26, 2020 •

edited

Loading

TravisBuddy commented Feb 26, 2020

liyasthomas commented Feb 26, 2020

dihmeetree commented Feb 26, 2020

liyasthomas commented Feb 26, 2020

TravisBuddy commented Feb 26, 2020

dihmeetree commented Feb 26, 2020 •

edited

Loading

TravisBuddy commented Feb 26, 2020

TravisBuddy commented Feb 26, 2020

TravisBuddy commented Feb 26, 2020

TravisBuddy commented Feb 26, 2020

GraphQL page improvements, and more #602

GraphQL page improvements, and more #602

Conversation

dihmeetree commented Feb 25, 2020 • edited Loading

ghost commented Feb 25, 2020 • edited by ghost Loading

DeepCode's analysis on #50339a found:

TravisBuddy commented Feb 25, 2020

TravisBuddy Request Identifier: d9c11890-578c-11ea-b14f-b186f6b55800

TravisBuddy commented Feb 25, 2020

TravisBuddy Request Identifier: 79380b30-578e-11ea-b14f-b186f6b55800

TravisBuddy commented Feb 25, 2020

TravisBuddy Request Identifier: 07c87c50-5793-11ea-b14f-b186f6b55800

TravisBuddy commented Feb 25, 2020

TravisBuddy Request Identifier: dcef4280-5796-11ea-acab-ef795e2c3319

TravisBuddy commented Feb 25, 2020

TravisBuddy Request Identifier: 65de5810-5797-11ea-acab-ef795e2c3319

TravisBuddy commented Feb 25, 2020

TravisBuddy Request Identifier: e7a81080-579b-11ea-acab-ef795e2c3319

TravisBuddy commented Feb 25, 2020

TravisBuddy Request Identifier: eb5a6d50-579f-11ea-acab-ef795e2c3319

liyasthomas commented Feb 25, 2020

dihmeetree commented Feb 26, 2020 • edited Loading

TravisBuddy commented Feb 26, 2020

TravisBuddy Request Identifier: 99ab8be0-583c-11ea-b533-891a36a4ac0b

liyasthomas commented Feb 26, 2020

dihmeetree commented Feb 26, 2020

liyasthomas commented Feb 26, 2020

TravisBuddy commented Feb 26, 2020

TravisBuddy Request Identifier: 081470d0-5840-11ea-b533-891a36a4ac0b

dihmeetree commented Feb 26, 2020 • edited Loading

TravisBuddy commented Feb 26, 2020

TravisBuddy Request Identifier: f633fef0-5842-11ea-b533-891a36a4ac0b

TravisBuddy commented Feb 26, 2020

TravisBuddy Request Identifier: 0d758f10-5844-11ea-b533-891a36a4ac0b

TravisBuddy commented Feb 26, 2020

TravisBuddy Request Identifier: b84611a0-584c-11ea-b533-891a36a4ac0b

TravisBuddy commented Feb 26, 2020

TravisBuddy Request Identifier: 7037f430-584e-11ea-b533-891a36a4ac0b

dihmeetree commented Feb 25, 2020 •

edited

Loading

ghost commented Feb 25, 2020 •

edited by ghost

Loading

dihmeetree commented Feb 26, 2020 •

edited

Loading

dihmeetree commented Feb 26, 2020 •

edited

Loading