fix(js): allow pinning importmaps with gem #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhenrixon
force-pushed
the
main
branch
2 times, most recently
from
9dfff06 to
ad1a108
Compare
Since import maps JSPM and the javascript ecosystem are a mess in their current state, allow import maps to match the assets served by the gem rather than download them from JSPM.
This was referenced Feb 12, 2024
hopsoft
approved these changes
Feb 12, 2024
hopsoft
approved these changes
Feb 12, 2024
hopsoft
added a commit
that referenced
this pull request
Feb 12, 2024
* Move from yarn to npm * fix(js): allow pinning importmaps with gem (#51) Since import maps JSPM and the javascript ecosystem are a mess in their current state, allow import maps to match the assets served by the gem rather than download them from JSPM. --------- Co-authored-by: Mikael Henriksson <mikael@mhenrixon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since import maps JSPM and the javascript ecosystem are a mess in their current state, allow import maps to match the assets served by the gem rather than download them from JSPM.
@hopsoft I will test this and reply if it works, but according to ChatGPT and the action cable source code, this is how it could be done. It may only work for my scenario, but I unblock myself this way.
That fixes that problem; I'm happy with this solution for now; seems fair since JSPM never updates. Perhaps we can update the documentation for importmaps to the following:
This is verified to be working with: