Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNB imports are not writing DNB id if a match is already found #1

Closed
hornc opened this issue Oct 6, 2021 · 6 comments
Closed

DNB imports are not writing DNB id if a match is already found #1

hornc opened this issue Oct 6, 2021 · 6 comments

Comments

@hornc
Copy link
Owner

hornc commented Oct 6, 2021

Example re-import edit:

https://openlibrary.org/books/OL27029002M/Das_indische_Tuch?_compare=Compare&b=5&a=4&m=diff

The source MARC was added, but the more useful DNB id (DNB200004271) was not.

@hornc
Copy link
Owner Author

hornc commented Oct 6, 2021

see internetarchive/openlibrary#5599 for relevant code area

@hornc
Copy link
Owner Author

hornc commented Dec 16, 2021

desired metadata update e.g.:

"identifiers": {"dnb": ["810887746"]}

(from https://openlibrary.org/books/OL30393926M/%C3%84thanol_und_h%C3%B6here_Alkohole_im_Serum_von_Diabetikern )

@hornc hornc changed the title DNB imports are not writing DNB id is a match is already found DNB imports are not writing DNB id if a match is already found Mar 14, 2022
hornc added a commit to hornc/openlibrary-1 that referenced this issue Mar 14, 2022
@hornc
Copy link
Owner Author

hornc commented Mar 29, 2022

Command to reimport and test https://openlibrary.org/books/OL27029002M/Das_indische_Tuch

./bulk-import.py -n 1 -o 512231530 -f dnb_all_dnbmarc_20200615-1.mrc marc_dnb_202006

After running this reimport, the record should have a DNB id of 200004271

@hornc
Copy link
Owner Author

hornc commented Mar 31, 2022

Now awaiting internetarchive/openlibrary#6351 to be merged and deployed for re-test.

@hornc
Copy link
Owner Author

hornc commented Apr 13, 2022

This code is currently on staging (Not yet on production), but the test has worked on staging:
https://staging.openlibrary.org/books/OL27029002M/Das_indische_Tuch?_compare=Compare&b=6&a=5&m=diff

@hornc
Copy link
Owner Author

hornc commented Apr 13, 2022

see also: https://openlibrary.org/books/OL26857113M/eiszeit-4000-utopisch-technischer-roman?_compare=Compare&b=4&a=3&m=diff for a working example of re-importing OCLC and DNB identifiers.

@hornc hornc closed this as completed Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant