Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed usage of VERBOSE=1 when setting custom MAKEFLAGS #2239

Merged
merged 2 commits into from
Sep 8, 2020
Merged

Fixed usage of VERBOSE=1 when setting custom MAKEFLAGS #2239

merged 2 commits into from
Sep 8, 2020

Conversation

tgaddair
Copy link
Collaborator

@tgaddair tgaddair commented Sep 4, 2020

When settings env variable MAKEFLAGS, the native args option -- is omitted, leading to error message Unknown argument VERBOSE=1.

@tgaddair
Fixed usage of VERBOSE=1 when setting custom MAKEFLAGS
6e58b59 
Signed-off-by: Travis Addair <taddair@uber.com>
leezu
leezu reviewed Sep 4, 2020
View reviewed changes
Dockerfile.cpu Outdated Show resolved Hide resolved
@tgaddair @leezu
Update Dockerfile.cpu
4bde570 
Co-authored-by: Leonard Lausen <leonard@lausen.nl>
nvcastet
nvcastet approved these changes Sep 8, 2020
View reviewed changes
Copy link
Collaborator

@nvcastet nvcastet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Travis!

@tgaddair tgaddair merged commit 567d3bd into master Sep 8, 2020
@tgaddair tgaddair deleted the makeflags branch September 8, 2020 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leezu leezu leezu left review comments

@nvcastet nvcastet nvcastet approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tgaddair @leezu @nvcastet