[CS] Improved tets for ZugferdDocumentValidator

horstoeko · Jan 27, 2025 · 9cbf227 · 9cbf227
1 parent c0716e0
commit 9cbf227
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 20 deletions.
diff --git a/src/ZugferdDocumentValidator.php b/src/ZugferdDocumentValidator.php
@@ -38,8 +38,7 @@ class ZugferdDocumentValidator
     /**
      * Constructor
      *
-     * @param              ZugferdDocument $document
-     * @codeCoverageIgnore
+     * @param ZugferdDocument $document
      */
     public function __construct(ZugferdDocument $document)
     {

diff --git a/tests/testcases/ValidatorInvalidTest.php b/tests/testcases/ValidatorInvalidTest.php
@@ -15,22 +15,15 @@ class ValidatorInvalidTest extends TestCase
      */
     protected static $document;
 
-    /**
-     * The validator instance
-     *
-     * @var ZugferdDocumentValidator
-     */
-    protected static $validator;
-
     public static function setUpBeforeClass(): void
     {
         self::$document = ZugferdDocumentReader::readAndGuessFromFile(__DIR__ . "/../assets/xml_en16931_5.xml");
-        self::$validator = new ZugferdDocumentValidator(self::$document);
     }
 
     public function testValidateDocument(): void
     {
-        $validationResult = self::$validator->validateDocument();
+        $validator = new ZugferdDocumentValidator(self::$document);
+        $validationResult = $validator->validateDocument();
         $this->assertCount(1, $validationResult);
         $this->assertArrayHasKey(0, $validationResult);
         $this->assertEquals("This value should not be null.", $validationResult[0]->getMessage());

diff --git a/tests/testcases/ValidatorValidTest.php b/tests/testcases/ValidatorValidTest.php
@@ -15,22 +15,15 @@ class ValidatorValidTest extends TestCase
      */
     protected static $document;
 
-    /**
-     * The validator instance
-     *
-     * @var ZugferdDocumentValidator
-     */
-    protected static $validator;
-
     public static function setUpBeforeClass(): void
     {
         self::$document = ZugferdDocumentReader::readAndGuessFromFile(__DIR__ . "/../assets/xml_en16931_1.xml");
-        self::$validator = new ZugferdDocumentValidator(self::$document);
     }
 
     public function testValidateDocument(): void
     {
-        $validationResult = self::$validator->validateDocument();
+        $validator = new ZugferdDocumentValidator(self::$document);
+        $validationResult = $validator->validateDocument();
         $this->assertCount(0, $validationResult);
     }
 }