DynamicOnTime: code moved from constructor to setup
#4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* All code initializing component callbacks have been moved from constructor to `setup()` method, new protected method `update_schedule_()` has been introduced to perform actual instatiation/configuration of `CronTrigger` instance - Removed `assert` on members since component schema now takes care of ensuring all configuration options are present
configuring component state callbacks
callbacks for `Number` and `Switch`, as solutions to properly cast to derived class in single loop over vector of base class instances seemingly imply more code than just two loops * `DynamicOnTime::setup()`: call `update_schedule_()` before setting callbacks above, to ensure all entities are created before callback would be called on them
* `DynamicOnTime`: `App.register_component()` is called in `setup` method only once, to simplify `update_schedule_()` * `DynamicOnTime::setup()`: fixed setting up state callbacks, those should be calling `this->update_schedule_()` not `this->setup()` * Added `DynamicOnTime::dump_config()` method to log configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setup()method, new protected methodupdate_schedule_()has been introduced to perform actual instantiation/configuration ofCronTriggerinstanceasserton members since component schema now takes care of ensuring all configuration options are presentDynamicOnTime:App.register_component()is called insetupmethod only once, to simplifyupdate_schedule_()DynamicOnTime::dump_config()method to log configuration