-
-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies (backend) #5642
Conversation
Signed-off-by: Taylor Smock <tsmock@meta.com>
Signed-off-by: Taylor Smock <tsmock@meta.com>
Signed-off-by: Taylor Smock <tsmock@meta.com>
Signed-off-by: Taylor Smock <tsmock@meta.com>
The primary change required was wrapping direct SQL commands with sqlalchemy.text (written as "sa.text"). Most of these could be converted to be not be written as direct SQL commands. Signed-off-by: Taylor Smock <tsmock@meta.com>
Signed-off-by: Taylor Smock <tsmock@meta.com>
This is largely paginate changes, along query methodology updates, and db execution method updates. There is also a change in backend/services/organisation_service.py that fixes a test failure (`datetime.today()` -> `func.now()`). Signed-off-by: Taylor Smock <tsmock@meta.com>
Signed-off-by: Taylor Smock <tsmock@meta.com>
Signed-off-by: Taylor Smock <tsmock@meta.com>
Also, add debug output for exception Signed-off-by: Taylor Smock <tsmock@meta.com>
…e shown by tests) Signed-off-by: Taylor Smock <tsmock@meta.com>
Signed-off-by: Taylor Smock <tsmock@meta.com>
SonarCloud Quality Gate failed. 0 Bugs No Coverage information |
Can someone check and see if c3bd7b8 is needed for other people? It might just be a configuration issue on the CI end (from docs/sysadmins/ci-cd.md, "[each] environment has its own set of environment variables which are stored as secrets in the CircleCI Organization Settings under Contexts.") |
I'm not sure. I'll find out. Is that what was causing the backend test failures? |
Merged. The changes will be deployed to staging. I'll report back if there are any problems. |
Yes, that is what was causing the most persistent backend test failure, and it was a pain to track down since it would pass if
I probably would have done the |
That's fair. I'll make the change. Edit to add: #5854 |
Sentry SDK now supports urllib3 >= 2.x https://github.com/getsentry/sentry-python/releases/tag/1.25.0 |
This PR intends to make the TM compatible with the defaults of Debian Bookworm. This means that the backend needs to be compatible with Python 3.11.
In general, the code changes are intended to be limited to compatibility changes. In the event that there needs to be a reformat due to formatting tool updates, those will be in separate commits (to make rebasing onto a new develop HEAD easier).
This PR replaces backend PRs #5649, #5629, #5591, #5590, #5563, #5480, #5457, #5420, #5385, #5348, #4591, and #4588.
EDIT: Additional backend PRs that are replaced are: #5770, #5761 (1.26.9 -> 1.26.15; sentry-sdk does not support 2.x), #5777, and #5747.
I highly recommend using the
Hide Whitespace
option in theDiff view
settings.EDIT: This also fixes #4906 and #5483 (see the
Fix gevent warning when run with gunicorn
commit).