Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove docs info about running independent dockerised postgres #6331

Merged

Conversation

spwoodcock
Copy link
Member

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation
  • πŸ§‘β€πŸ’» Refactor
  • βœ… Test
  • πŸ€– Build or CI
  • ❓ Other (please specify)

Related Issue

Fixes #4223

Describe this PR

  • We handle this by default in the docker compose config.
  • If the user needs a dockerised postgres instance, that is running outside of the TM stack, they have an advanced use case & I am sure setting up a postgres container would be trivial to them.

Checklist before requesting a review

[optional] What gif best describes this PR or how it makes you feel?

@spwoodcock spwoodcock marked this pull request as ready for review April 11, 2024 14:48
Copy link

sonarcloud bot commented Apr 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@ramyaragupathy ramyaragupathy added scope: documentation Any issue that relates to documentation edits, updates, improvements dev-setup πŸ› οΈ labels May 2, 2024
@spwoodcock
Copy link
Member Author

Looks good to merge @ramyaragupathy πŸ‘

@spwoodcock spwoodcock force-pushed the docs/info-for-postgres-docker branch from defee6f to 85a65aa Compare July 30, 2024 19:01
Copy link

sonarcloud bot commented Jul 30, 2024

@spwoodcock spwoodcock merged commit 2662786 into hotosm:develop Sep 5, 2024
7 checks passed
@spwoodcock spwoodcock deleted the docs/info-for-postgres-docker branch September 5, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev-setup πŸ› οΈ scope: documentation Any issue that relates to documentation edits, updates, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation link for postgres docker image is broken
3 participants