Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ssm permissions to pull the AMI #6514

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Fix ssm permissions to pull the AMI #6514

merged 1 commit into from
Jul 30, 2024

Conversation

dakotabenjamin
Copy link
Member

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • [x ] πŸ› Bug Fix
  • πŸ“ Documentation
  • πŸ§‘β€πŸ’» Refactor
  • βœ… Test
  • [x ] πŸ€– Build or CI
  • ❓ Other (please specify)

Related Issue

Example: Fixes #6512 regression

Describe this PR

I had tested the PR using a role with admin level permissions, so I didn't catch the lack of permissions needed to GetParameters:

19:41:35Z *********: UPDATE_FAILED TaskingManagerLaunchTemplate: Resource handler returned message: "User: arn:aws:sts::************:assumed-role/*********************/backend-deploy is not authorized to perform: ssm:GetParameters on resource: arn:aws:ssm:*********:************:parameter/ami-01e5ff16fd6e8c542 because no identity-based policy allows the ssm:GetParameters action ...

Screenshots

Please provide screenshots of the change.

Alternative Approaches Considered

Did you attempt any other approaches that are not documented in code?

Review Guide

Notes for the reviewer. How to test this change?

Checklist before requesting a review

[optional] What gif best describes this PR or how it makes you feel?

@dakotabenjamin
Copy link
Member Author

fyi @tsmock

Copy link

sonarcloud bot commented Jul 30, 2024

@dakotabenjamin dakotabenjamin merged commit 167ff31 into develop Jul 30, 2024
9 checks passed
@tsmock
Copy link
Contributor

tsmock commented Jul 30, 2024

That is funny; I didn't need it for my deployment. Although I was using the Terraform cloudformation_stack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants