Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mapswipe group ID to partners #6542

Conversation

bshankar
Copy link
Collaborator

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation

Related Issue

Fixes #6536

Describe this PR

This PR makes the following changes:

  1. Add a new column to the table partners to store mapswipe_group_id
  2. Modify the DTOs and partners API for GET, POST and PUT requests to accommodate this new column.
  3. Add a new input field in the UI for an admin to populate this field while creating or editing a partner.
  4. Fix API crash during partner creation when required fields are not provided.

Screenshots

Screenshot from 2024-08-22 18-53-03(1)

@emi420
Copy link
Collaborator

emi420 commented Aug 22, 2024

@bshankar we should merge this PR also, with fixed and updated docs:

https://github.com/hotosm/tasking-manager/pull/6520/files

Would you merge it directly to your branch?

Copy link
Collaborator

@emi420 emi420 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks ok to me!

@bshankar
Copy link
Collaborator Author

@bshankar we should merge this PR also, with fixed and updated docs:

https://github.com/hotosm/tasking-manager/pull/6520/files

Would you merge it directly to your branch?

Done!

Copy link

sonarcloud bot commented Aug 23, 2024

@ramyaragupathy ramyaragupathy merged commit c973f33 into hotosm:develop Sep 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support linking of partners to MapSwipe group ID
5 participants