Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue with Order Fulfillment Capacity Input Validation in Shipping Facility Tab #332

Closed
Adameddy26 opened this issue May 23, 2024 · 2 comments
Closed

Issue with Order Fulfillment Capacity Input Validation in Shipping Facility Tab #332

Adameddy26 opened this issue May 23, 2024 · 2 comments
Assignees
@Adameddy26
Labels
bug Something isn't working release-v3.1.0

Comments

@Adameddy26
Copy link

Expected behavior

The input field should be blank when switching from 'No capacity' to 'custom' option, and upon saving, it should validate values correctly, prompting appropriate toast messages.

Steps to reproduce the issue

Navigate to the Shipping Facility tab.
Choose 'No capacity' option for order fulfillment capacity of a facility.
Switch to 'custom' option for the same.
Observe '0' displayed in the modal instead of a blank value.
Attempt to save with '0' as the input.
Note the toast message: "Please provide a value."
Rewrite '0' in the same field.
Attempt to save again.
Note the toast message: "Please provide a value greater than 0".

Environment details

App version : THRESHOLD-2.0-2C00FE9
App environment : DEV

Additional information

https://jam.dev/c/5de9497d-8a54-4be5-8805-18833f4f513a
@Adameddy26 Adameddy26 added the bug Something isn't working label May 23, 2024
@amansinghbais amansinghbais moved this from 📋 Backlog to 🏗 In progress in Digital Experience Platform May 27, 2024
@amansinghbais amansinghbais moved this from 🏗 In progress to 📋 Backlog in Digital Experience Platform May 28, 2024
@amansinghbais amansinghbais moved this from 📋 Backlog to 🏗 In progress in Digital Experience Platform Jul 19, 2024
amansinghbais added a commit to amansinghbais/threshold-management that referenced this issue Jul 19, 2024
@amansinghbais
Fixed: wrong toast message in custom orderlimit alert when prefilled …
ce4f37c 
…with 0, and added missing translation entry (hotwax#332)
@amansinghbais amansinghbais mentioned this issue Jul 19, 2024
Merged
1 task
@amansinghbais amansinghbais moved this from 🏗 In progress to 👀 In review in Digital Experience Platform Jul 19, 2024
@amansinghbais
Copy link
Contributor

amansinghbais commented Jul 19, 2024 •
edited
Loading

Based on discussion, we'll be showing blank input when limit is set to unlimited, while we will be showing 0 as prefilled when maxOrderLimit is set to no capacity.

ymaheshwari1 added a commit that referenced this issue Jul 22, 2024
@ymaheshwari1
Merge pull request #362 from amansinghbais/#332
1f3f2c2 
Fixed: wrong toast message getting displayed when custom orderLimit value prefilled with 0 (#332)
@ymaheshwari1 ymaheshwari1 moved this from 👀 In review to ⏸️ Dev complete in Digital Experience Platform Jul 22, 2024
@Adameddy26 Adameddy26 moved this from ⏸️ Dev complete to 🛠 In QA in Digital Experience Platform Aug 12, 2024
@Adameddy26 Adameddy26 self-assigned this Aug 12, 2024
@Adameddy26
Copy link
Author

Verified and working fine in release v3.1.0. Hence, closing it.
https://jam.dev/c/abe306be-9097-4ec8-aa4b-c35d9650a481

@github-project-automation github-project-automation bot moved this from 🛠 In QA to ✅ Done in Digital Experience Platform Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Adameddy26 Adameddy26

Labels
bug Something isn't working release-v3.1.0
Projects
Digital Experience Platform
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@amansinghbais @Adameddy26