Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show spinner in assign picker modal until the pickers list is fetched #444

Closed
3 tasks
amansinghbais opened this issue Oct 21, 2024 · 1 comment
Closed
3 tasks

Show spinner in assign picker modal until the pickers list is fetched #444

amansinghbais opened this issue Oct 21, 2024 · 1 comment
Assignees
@Adameddy26
Labels
release-v2.26.3

Comments

@amansinghbais
Copy link
Contributor

What is the motivation for adding/enhancing this feature?

Currently when we open AssignPicker modal it shows us "no picker found" until pickers list is fetched. Which results in confusion to user.

For better user experience we should show spinner telling user that list is being fetched.

What are the acceptance criteria?

  • ...

Can you complete this feature request by yourself?

  • YES
  • NO

Additional information
@amansinghbais amansinghbais self-assigned this Oct 21, 2024
@amansinghbais amansinghbais moved this from 📋 Backlog to 🏗 In progress in Digital Experience Platform Oct 21, 2024
amansinghbais added a commit to amansinghbais/bopis that referenced this issue Oct 21, 2024
@amansinghbais
Improved: showing ion spinner until picker list is being fetched (hot…
92cd4f9 
…wax#444)
@amansinghbais amansinghbais mentioned this issue Oct 21, 2024
Merged
1 task
amansinghbais added a commit to amansinghbais/bopis that referenced this issue Oct 21, 2024
@amansinghbais
Improved: used empty-state class in no record found (hotwax#444)
18f060f
ravilodhi added a commit that referenced this issue Oct 21, 2024
@ravilodhi
Merge pull request #445 from amansinghbais/#444
c11efee 
Improved: showing ion spinner until picker list is being fetched (#444)
@ravilodhi ravilodhi moved this from 🏗 In progress to ⏸️ Dev complete in Digital Experience Platform Oct 21, 2024
amansinghbais added a commit to amansinghbais/bopis that referenced this issue Oct 21, 2024
@amansinghbais
Fixed: stopped spinner to show on infinite scrolling (hotwax#444)
3d22652
@amansinghbais amansinghbais mentioned this issue Oct 21, 2024
Merged
1 task
ravilodhi added a commit that referenced this issue Oct 21, 2024
@ravilodhi
Merge pull request #446 from amansinghbais/#444
b9fdd69 
Fixed: stopped spinner to show on infinite scrolling (#444)
amansinghbais added a commit to amansinghbais/bopis that referenced this issue Oct 21, 2024
@amansinghbais
Implemented: spinner inside of the edit picker modal (hotwax#444)
8469575
@amansinghbais amansinghbais mentioned this issue Oct 21, 2024
Merged
1 task
ravilodhi added a commit that referenced this issue Oct 21, 2024
@ravilodhi
Merge pull request #449 from amansinghbais/#444
56c0526 
Implemented: spinner inside of the edit picker modal (#444)
@Adameddy26 Adameddy26 moved this from ⏸️ Dev complete to 🛠 In QA in Digital Experience Platform Oct 21, 2024
@Adameddy26
Copy link

Changes verified and working fine in release v2.26.3. Hence, closing this ticket
image

@github-project-automation github-project-automation bot moved this from 🛠 In QA to ✅ Done in Digital Experience Platform Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Adameddy26 Adameddy26

Labels
release-v2.26.3
Projects
Digital Experience Platform
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@amansinghbais @Adameddy26