Implemented: Add time zone support and migrated from moment to luxon(#25k8h53) #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ymaheshwari1
requested changes
Jun 27, 2022
ymaheshwari1
requested changes
Jun 28, 2022
src/views/TimezoneModal.vue
Outdated
| <div v-else> | ||
| <ion-list> | ||
| <ion-radio-group value="rd" v-model="timeZoneId"> | ||
| <ion-item v-bind:key="timeZone.id" v-for="timeZone in filteredTimeZones"> |
There was a problem hiding this comment.
Suggested change
| <ion-item v-bind:key="timeZone.id" v-for="timeZone in filteredTimeZones"> | |
| <ion-item :key="timeZone.id" v-for="timeZone in filteredTimeZones"> |
src/views/TimezoneModal.vue
Outdated
| <ion-title>{{ $t("Select time zone") }}</ion-title> | ||
| </ion-toolbar> | ||
| <ion-toolbar> | ||
| <ion-searchbar @ionFocus="selectSearchBarText($event)" :placeholder="$t('Search time zones')" v-model="queryString" v-on:keyup.enter="queryString = $event.target.value; findTimeZone()" /> |
There was a problem hiding this comment.
Add the static text to en.json
src/views/TimezoneModal.vue
Outdated
| <ion-title>{{ $t("Select time zone") }}</ion-title> | ||
| </ion-toolbar> | ||
| <ion-toolbar> | ||
| <ion-searchbar @ionFocus="selectSearchBarText($event)" :placeholder="$t('Search time zones')" v-model="queryString" v-on:keyup.enter="queryString = $event.target.value; findTimeZone()" /> |
There was a problem hiding this comment.
Suggested change
| <ion-searchbar @ionFocus="selectSearchBarText($event)" :placeholder="$t('Search time zones')" v-model="queryString" v-on:keyup.enter="queryString = $event.target.value; findTimeZone()" /> | |
| <ion-searchbar @ionFocus="selectSearchBarText($event)" :placeholder="$t('Search time zones')" v-model="queryString" @keyup.enter="queryString = $event.target.value; findTimeZone()" /> |
src/views/TimezoneModal.vue
Outdated
| <ion-radio-group value="rd" v-model="timeZoneId"> | ||
| <ion-item v-bind:key="timeZone.id" v-for="timeZone in filteredTimeZones"> | ||
| <ion-label>{{ timeZone.label }} ({{ timeZone.id }})</ion-label> | ||
| <ion-radio :value="timeZone.id" slot="start"></ion-radio> |
There was a problem hiding this comment.
Use self-closing tag.
|
Dependent on #90 |
1 task
ymaheshwari1
requested changes
Jul 6, 2022
src/App.vue
Outdated
| @@ -57,6 +57,6 @@ export default defineComponent({ | |||
| unmounted() { | |||
| emitter.off('presentLoader', this.presentLoader); | |||
| emitter.off('dismissLoader', this.dismissLoader); | |||
| }, | |||
There was a problem hiding this comment.
Remove this unwanted change.
3 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes #
Short Description and Why It's Useful
Screenshots of Visual Changes before/after (If There Are Any)
IMPORTANT NOTICE - Remember to add changelog entry
Contribution and Currently Important Rules Acceptance