implemented: support to add picker for ready to pick orders(#85zrnzf31) #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated: logic to store pickers details in data property in assignPickerModal instead of state as we are caching the api calls removed unwanted code fix ui in case of no picker found(#85zrnzf31)
adityasharma7
suggested changes
Mar 2, 2023
| const formData = new FormData(); | ||
| formData.append("facilityId", items[0].facilityId); | ||
| items.map((item: any) => { | ||
| formData.append("itemStatusId_o_"+items.indexOf(item), "PICKITEM_PENDING") |
There was a problem hiding this comment.
I think map method has index
map((element, index) => { /* … */ })
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/map#syntax
| import { translate } from '@/i18n' | ||
|
|
||
| const actions: ActionTree<PicklistState, RootState> = { | ||
| async createPicklist ({ commit }, payload) { |
There was a problem hiding this comment.
We do not need state for this, we could use methods. We are not storing anything shared in state
src/views/AssignPickerModal.vue
Outdated
| // TODO: having issue when creating more than 2 groups in performFind, searching always work on first two groups | ||
| // For now enabled searching on first name and externalId | ||
| inputFields = { | ||
| firstName_fld0_value: this.queryString, |
There was a problem hiding this comment.
We do need fld0 and fld1
Suggested change
| firstName_fld0_value: this.queryString, | |
| firstName_fld0_value: this.queryString, |
src/views/AssignPickerModal.vue
Outdated
| event.target.complete(); | ||
| }); | ||
| }, | ||
| async fetchPickers(vSize, vIndex) { |
There was a problem hiding this comment.
Suggested change
| async fetchPickers(vSize, vIndex) { | |
| async getPicker(vSize, vIndex) { |
src/views/AssignPickerModal.vue
Outdated
| total = resp.data.count; | ||
| } else { | ||
| console.error(translate('Something went wrong')) | ||
| this.availablePickers = []; |
There was a problem hiding this comment.
I think this empty list for pagination as well. Same in catch block
src/store/modules/user/index.ts
Outdated
| @@ -14,7 +14,8 @@ const userModule: Module<UserState, RootState> = { | |||
| instanceUrl: '', | |||
| preference: { | |||
| showShippingOrders: true, | |||
| showPackingSlip: false | |||
| showPackingSlip: false, | |||
| configurePicker: true, | |||
There was a problem hiding this comment.
By default it should be false, as pre the current behaviour
adityasharma7
suggested changes
Mar 2, 2023
src/store/modules/order/actions.ts
Outdated
Comment on lines
392
to
402
| if (resp.status === 200 && !hasError(resp) && resp.data) { | ||
| if(!(resp.data.picklistId && resp.data.picklistBinId)) { | ||
| showToast(translate('Something went wrong. Picklist can not be created.')); | ||
| emitter.emit("dismissLoader"); | ||
| return; | ||
| } | ||
| } else { | ||
| showToast(translate('Something went wrong. Picklist can not be created.')); | ||
| emitter.emit("dismissLoader"); | ||
| return; | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (resp.status === 200 && !hasError(resp) && resp.data) { | |
| if(!(resp.data.picklistId && resp.data.picklistBinId)) { | |
| showToast(translate('Something went wrong. Picklist can not be created.')); | |
| emitter.emit("dismissLoader"); | |
| return; | |
| } | |
| } else { | |
| showToast(translate('Something went wrong. Picklist can not be created.')); | |
| emitter.emit("dismissLoader"); | |
| return; | |
| } | |
| if (resp.status !== 200 || hasError(resp) || !(resp.data.picklistId && resp.data.picklistBinId)) { | |
| showToast(translate('Something went wrong. Picklist can not be created.')); | |
| emitter.emit("dismissLoader"); | |
| return; | |
| } |
adityasharma7
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes #186
Short Description and Why It's Useful
Screenshots of Visual Changes before/after (If There Are Any)
Contribution and Currently Important Rules Acceptance