Implemented: dropdown for other shipments in a order in order details page (#358) #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ymaheshwari1
requested changes
Jan 8, 2024
src/services/OrderService.ts
Outdated
| @@ -258,8 +258,52 @@ const getShippingPhoneNumber = async (orderId: string): Promise<any> => { | |||
| return phoneNumber | |||
| } | |||
|
|
|||
| const findOrderShipGroup = async (query: any): Promise<any> => { | |||
| return api({ | |||
| // TODO: We can replace this with any API | |||
src/store/modules/order/actions.ts
Outdated
|
|
||
| const params = { | ||
| groupBy: 'shipGroupSeqId', | ||
| 'shipGroupSeqId': '[* TO *]', // check to ignore all those records for which shipGroupSeqId is not present, as in case of kit comp we does not get shipGroupSeqId on some items |
src/store/modules/order/actions.ts
Outdated
| resp = await OrderService.findOrderShipGroup(orderQueryPayload); | ||
|
|
||
| if (resp.status === 200 && !hasError(resp) && resp.data.grouped?.shipGroupSeqId.matches > 0) { | ||
| total = resp.data.grouped.shipGroupSeqId.ngroups |
ymaheshwari1
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes #358
Short Description and Why It's Useful
Implemented code to display other shipments in a order in order details page.
Screenshots of Visual Changes before/after (If There Are Any)
Contribution and Currently Important Rules Acceptance