Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: Allowed search on groupName to handle the case where picker is a party group(#389) #390

Merged
merged 4 commits into from
May 1, 2024

Conversation

R-Sourabh
Copy link
Contributor

@R-Sourabh R-Sourabh commented Apr 30, 2024

Related Issues

#389

Short Description and Why It's Useful

  • Update the payload of the function which is responsible for searching.
  • Added properties related to group and mention the number of fields in which the searching should perform.

Screenshots of Visual Changes before/after (If There Are Any)

Screenshot from 2024-04-30 12-32-38

Contribution and Currently Important Rules Acceptance

Copy link
Contributor

@ymaheshwari1 ymaheshwari1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also handle the case to display groupName if available otherwise display firstName + ' ' + lastName

src/components/EditPickerModal.vue Outdated Show resolved Hide resolved
src/views/AssignPickerModal.vue Outdated Show resolved Hide resolved
src/components/EditPickerModal.vue Outdated Show resolved Hide resolved
@ymaheshwari1 ymaheshwari1 merged commit 8fd0f7a into hotwax:main May 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants