Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved: changing the state of notification preference toggle only if api success (#405) #406

Merged
merged 3 commits into from
Jul 5, 2024

Conversation

amansinghbais
Copy link
Contributor

Related Issues

#405

Short Description and Why It's Useful

Improved notification preferences updation logic so as to change toggle state only if preference updates successfully.

Screenshots of Visual Changes before/after (If There Are Any)

Contribution and Currently Important Rules Acceptance

src/store/modules/user/actions.ts Outdated Show resolved Hide resolved
src/views/Settings.vue Show resolved Hide resolved
@ymaheshwari1 ymaheshwari1 merged commit ccf4ae4 into hotwax:main Jul 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants