Improved: logic to show rejection reason options based on admin permission (#438) #440
Conversation
|
OMS 5.18.0 Dependant. A view entity is added and the related PR got merged on Oct 17, 2024. |
| @@ -92,7 +92,8 @@ export default defineComponent({ | |||
| modalController.dismiss({ dismissed: true }); | |||
| }, | |||
| getRejectReasonDescription(rejectReasonEnumId: string) { | |||
| return this.rejectReasons.find((reason: any) => reason.enumId === rejectReasonEnumId)?.description; | |||
| const reason = this.rejectReasons.find((reason: any) => reason.enumId === rejectReasonEnumId) | |||
| return reason?.description ? reason.description : reason?.enumDescription; | |||
There was a problem hiding this comment.
These checks might lead to an incorrect description. My understanding is that we’re fetching data from two different view entities:
For Admin users: EnumTypeChildAndEnum
For other users: EnumerationGroupAndMember
In the case of an Admin user, the current logic works as expected. However, for other users, it may not work correctly because the EnumerationGroupAndMember view contains both description and enumDescription fields. Here, description refers to EnumGroup.description, while enumDescription refers to Enumeration.description.
Let me know if I am thinking wrong.
There was a problem hiding this comment.
This will not give issue, since we are not fetching description field in case of EnumerationGroupAndMember, so we won't have description and EnumDescription at the same time.
…fetching bopis group reasons (hotwax#438)
Related Issues
#438
Short Description and Why It's Useful
Showing all rejection reasons only if user is admin else showing only the reasons from the bopis group.
Screenshots of Visual Changes before/after (If There Are Any)
Contribution and Currently Important Rules Acceptance