Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[POC] Create a reusable component for product identifier setting #95

Closed
ymaheshwari1 opened this issue Jun 12, 2023 · 2 comments
Closed

[POC] Create a reusable component for product identifier setting #95

ymaheshwari1 opened this issue Jun 12, 2023 · 2 comments
Assignees
@ymaheshwari1
Labels
enhancement New feature or request

Comments

@ymaheshwari1
Copy link
Contributor

No description provided.

@ymaheshwari1 ymaheshwari1 self-assigned this Jun 12, 2023
@ymaheshwari1 ymaheshwari1 moved this to 🏗 In progress in Digital Experience Platform Jun 12, 2023
@ymaheshwari1
Copy link
Contributor Author

For now, we have just defined the logic part in #94, but we will create the complete UI component. So for now moving this issue in backlog.

@ymaheshwari1 ymaheshwari1 moved this from 🏗 In progress to 📋 Backlog in Digital Experience Platform Jul 10, 2023
@ymaheshwari1 ymaheshwari1 moved this from 📋 Backlog to 🏗 In progress in Digital Experience Platform Sep 1, 2023
ymaheshwari1 added a commit to ymaheshwari1/ionic-sdk that referenced this issue Sep 4, 2023
@ymaheshwari1
Implemented: support to use ionic components in dxp components(hotwax#95
21302be 
)
ymaheshwari1 added a commit to ymaheshwari1/ionic-sdk that referenced this issue Sep 4, 2023
@ymaheshwari1
Merge branch 'main' into dxp-components/hotwax#95-ionic
db90371
ymaheshwari1 added a commit to ymaheshwari1/ionic-sdk that referenced this issue Sep 4, 2023
@ymaheshwari1
Removed: user info component as added it for testing(hotwax#95)
1d96a42
ymaheshwari1 added a commit to ymaheshwari1/ionic-sdk that referenced this issue Sep 5, 2023
@ymaheshwari1
Fixed: warning in console regarding duplicate vue instances(hotwax#95)
e6322ba
ymaheshwari1 added a commit to ymaheshwari1/ionic-sdk that referenced this issue Sep 7, 2023
@ymaheshwari1
Removed: config for allow js files in the module(hotwax#95)
2cf0a90
ravilodhi added a commit that referenced this issue Sep 7, 2023
@ravilodhi
Merge pull request #130 from ymaheshwari1/dxp-components/#95-ionic
8566042 
Implemented: support to use ionic components in dxp components(#95)
sanskar345 added a commit to sanskar345/dxp-components that referenced this issue Sep 7, 2023
@sanskar345
Merge branch 'dxp-components/hotwax#95-ionic' of https://github.com/y…
70bb837 
…maheshwari1/ionic-sdk into dxp-components/hotwax#134
@Dhiraj1405 Dhiraj1405 added the enhancement New feature or request label Sep 8, 2023
@ymaheshwari1 ymaheshwari1 moved this from 🏗 In progress to 📅 Planned in Digital Experience Platform Sep 11, 2023
@ymaheshwari1 ymaheshwari1 moved this from 📅 Planned to 🏗 In progress in Digital Experience Platform Sep 14, 2023
ymaheshwari1 added a commit to ymaheshwari1/ionic-sdk that referenced this issue Sep 14, 2023
@ymaheshwari1
Implemented: support for product identifier component using ionic(hot…
95c238c 
…wax#95)
ymaheshwari1 added a commit to ymaheshwari1/ionic-sdk that referenced this issue Sep 14, 2023
@ymaheshwari1
Implemented: logic to fetch the identification for the current store …
49399b1 
…on component mounted(hotwax#95)
ymaheshwari1 added a commit to ymaheshwari1/ionic-sdk that referenced this issue Sep 14, 2023
@ymaheshwari1
Improved: code to make the identifier fetch from api reactive(hotwax#95)
3b7141c
ymaheshwari1 added a commit to ymaheshwari1/ionic-sdk that referenced this issue Sep 14, 2023
@ymaheshwari1
Removed: console statements, added some todos and added logic to set …
bbfef1e 
…the product identification(hotwax#95)
ymaheshwari1 added a commit to ymaheshwari1/ionic-sdk that referenced this issue Sep 14, 2023
@ymaheshwari1
Updated: package and lock file(hotwax#95)
66588ab
ravilodhi added a commit that referenced this issue Sep 14, 2023
@ravilodhi
Merge pull request #163 from ymaheshwari1/dxp-components/product-iden…
91b10f4 
…tifier-#95

Implemented: support for product identifier component using dxp-component(#95)
@ymaheshwari1 ymaheshwari1 moved this from 🏗 In progress to 👀 In review in Digital Experience Platform Sep 15, 2023
@Dhiraj1405 Dhiraj1405 moved this from 👀 In review to ✅ Done in Digital Experience Platform Sep 22, 2023
@ymaheshwari1
Copy link
Contributor Author

Closing as the implementation of the same in apps will be handled in #178

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ymaheshwari1 ymaheshwari1

Labels
enhancement New feature or request
Projects
Digital Experience Platform
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ymaheshwari1 @Dhiraj1405