Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to ionic 7 #162

Closed
ymaheshwari1 opened this issue Jan 8, 2024 · 3 comments · Fixed by #170
Closed

Migrate to ionic 7 #162

ymaheshwari1 opened this issue Jan 8, 2024 · 3 comments · Fixed by #170
Assignees
@Adameddy26
Labels
enhancement New feature or request release-v1.6.0 release-v1.6.1

Comments

@ymaheshwari1
Copy link
Contributor

No description provided.

@ymaheshwari1 ymaheshwari1 self-assigned this Jan 8, 2024
@ymaheshwari1 ymaheshwari1 moved this to 📋 Backlog in Digital Experience Platform Jan 8, 2024
ymaheshwari1 added a commit to ymaheshwari1/facilities that referenced this issue Jan 9, 2024
@ymaheshwari1
Improved: app to upgrade ionic to v7.6.0(hotwax#162)
1c36b02
ymaheshwari1 added a commit to ymaheshwari1/facilities that referenced this issue Jan 9, 2024
@ymaheshwari1
Improved: app theme version to latest(hotwax#162)
0c227ec
ymaheshwari1 added a commit to ymaheshwari1/facilities that referenced this issue Jan 9, 2024
@ymaheshwari1
Improved: usage of ion-radio as per the changes in ionic7(hotwax#162)
17c843f
ymaheshwari1 added a commit to ymaheshwari1/facilities that referenced this issue Jan 9, 2024
@ymaheshwari1
Improved: usage of different components on facility details page and …
34c51ec 
…related components(hotwax#162)
ymaheshwari1 added a commit to ymaheshwari1/facilities that referenced this issue Jan 9, 2024
@ymaheshwari1
Updated: styling for card-header to change the direction to row(hotwa…
c29a4c8 
…x#162)
ymaheshwari1 added a commit to ymaheshwari1/facilities that referenced this issue Jan 9, 2024
@ymaheshwari1
Fixed: usage of components on find groups page(hotwax#162)
73b6866
ymaheshwari1 added a commit to ymaheshwari1/facilities that referenced this issue Jan 10, 2024
@ymaheshwari1
Fixed: usage of components in create group modal(hotwax#162)
4e5a76c
ymaheshwari1 added a commit to ymaheshwari1/facilities that referenced this issue Jan 10, 2024
@ymaheshwari1
Improved: usage of components on parking page(hotwax#162)
7829cfb
@ymaheshwari1 ymaheshwari1 mentioned this issue Jan 10, 2024
Merged
1 task
ymaheshwari1 added a commit to ymaheshwari1/facilities that referenced this issue Jan 10, 2024
@ymaheshwari1
Fixed: component usage in facility create flow(hotwax#162)
389134f
ymaheshwari1 added a commit to ymaheshwari1/facilities that referenced this issue Jan 10, 2024
@ymaheshwari1
Fixed: ion-toggle label issue(hotwax#162)
8421113
@ymaheshwari1 ymaheshwari1 moved this from 📋 Backlog to 👀 In review in Digital Experience Platform Jan 10, 2024
@ymaheshwari1 ymaheshwari1 moved this from 👀 In review to 📅 Planned in Digital Experience Platform Mar 28, 2024
@amansinghbais amansinghbais moved this from 📅 Planned to 🏗 In progress in Digital Experience Platform Mar 28, 2024
amansinghbais added a commit to amansinghbais/facilities that referenced this issue Mar 28, 2024
@amansinghbais
Merge branch 'main' of https://github.com/hotwax/facilities into hotw…
9d6e457 
…ax#162
amansinghbais added a commit to amansinghbais/facilities that referenced this issue Mar 28, 2024
@amansinghbais
Improved: updated code according to the needs for ionic 7 (hotwax#162)
4914c39
amansinghbais added a commit to amansinghbais/facilities that referenced this issue Mar 28, 2024
@amansinghbais
Improved: label for ion-inputs according to ionic 7 (hotwax#162)
f34ef71
amansinghbais added a commit to amansinghbais/facilities that referenced this issue Mar 28, 2024
@amansinghbais
Improved: used div instead of ion-label for showing label in ion-input (
75217d9 
hotwax#162)
amansinghbais added a commit to amansinghbais/facilities that referenced this issue Mar 28, 2024
@amansinghbais
Improved: used ref property on the ion-input instead of on ion-item (h…
67e1ebb 
…otwax#162)
@amansinghbais amansinghbais mentioned this issue Mar 28, 2024
Merged
1 task
amansinghbais added a commit to amansinghbais/facilities that referenced this issue Mar 28, 2024
@amansinghbais
Fixed: facility type not updating issue, and shopifyShopId getting is…
4ab4fe4 
…sue (hotwax#162)
@amansinghbais amansinghbais moved this from 🏗 In progress to 👀 In review in Digital Experience Platform Mar 28, 2024
amansinghbais added a commit to amansinghbais/facilities that referenced this issue Apr 1, 2024
@amansinghbais
Merge branch 'main' of https://github.com/hotwax/facilities into hotw…
0c6593d 
…ax#162
ravilodhi added a commit that referenced this issue Apr 9, 2024
@ravilodhi
Merge pull request #234 from amansinghbais/#162
3c36c01 
Improved: upgraded ionic to v7.6.0 (#162)
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Digital Experience Platform Apr 9, 2024
@Adameddy26
Copy link

It has been observed that while creating a facility, placeholder text of Zipcode is not visible to user which is causing difficulty in identifying the field purpose. Also when left blank, user is getting the error message and not able to create the facility as it is a mandatory field.
https://jam.dev/c/117f207c-4e6e-41e6-a2c7-c12ff43e5a78

Hence, reopening this ticket.

@Adameddy26 Adameddy26 reopened this Apr 10, 2024
@github-project-automation github-project-automation bot moved this from ✅ Done to 📅 Planned in Digital Experience Platform Apr 10, 2024
@Adameddy26 Adameddy26 added enhancement New feature or request release-v1.6.0 labels Apr 10, 2024
@amansinghbais amansinghbais moved this from 📅 Planned to 🏗 In progress in Digital Experience Platform Apr 10, 2024
amansinghbais added a commit to amansinghbais/facilities that referenced this issue Apr 10, 2024
@amansinghbais
Fixed: zipcode label not showing in facility address modal (hotwax#162)
4d9caf8
@amansinghbais amansinghbais mentioned this issue Apr 10, 2024
Merged
1 task
@amansinghbais amansinghbais moved this from 🏗 In progress to 👀 In review in Digital Experience Platform Apr 10, 2024
ymaheshwari1 added a commit that referenced this issue Apr 10, 2024
@ymaheshwari1
Merge pull request #238 from amansinghbais/#162
89af8c6 
Fixed: zipcode label not showing in facility address modal (#162)
@ymaheshwari1 ymaheshwari1 moved this from 👀 In review to ⏸️ Dev complete in Digital Experience Platform Apr 10, 2024
@Adameddy26 Adameddy26 moved this from ⏸️ Dev complete to 🛠 In QA in Digital Experience Platform Apr 23, 2024
@Adameddy26
Copy link

It has been observed that while creating a facility, placeholder text of Zipcode is not visible to user which is causing difficulty in identifying the field purpose. Also when left blank, user is getting the error message and not able to create the facility as it is a mandatory field. https://jam.dev/c/117f207c-4e6e-41e6-a2c7-c12ff43e5a78

Hence, reopening this ticket.

Issue verified and working fine in release v1.6.1. Hence, closing this ticket.
https://jam.dev/c/6df757dd-bd8f-455e-b7e7-a94d6b40c391

@github-project-automation github-project-automation bot moved this from 🛠 In QA to ✅ Done in Digital Experience Platform Apr 23, 2024
R-Sourabh added a commit to R-Sourabh/facilities that referenced this issue Apr 29, 2024
@R-Sourabh
Fixed: html tags not working in the translations (hotwax#162)
7201d3c
@R-Sourabh R-Sourabh mentioned this issue Apr 29, 2024
Merged
1 task
ymaheshwari1 added a commit that referenced this issue Apr 29, 2024
@ymaheshwari1
Merge pull request #251 from R-Sourabh/#162-html-template
6326c7c 
Fixed: html tags not working in the translations (#162)
@Adameddy26
Copy link

https://jam.dev/c/71d02cad-ea25-4cf9-aec6-54935d791877


tag issue in alert is working fine in latest release v1.7.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Adameddy26 Adameddy26

Labels
enhancement New feature or request release-v1.6.0 release-v1.6.1
Projects
Digital Experience Platform
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improved: app to upgrade ionic to v7.6.0(#162) ymaheshwari1/facilities
3 participants
@ymaheshwari1 @amansinghbais @Adameddy26