Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Card content is hidden behind the tab-bar #289

Closed
1 of 2 tasks
ymaheshwari1 opened this issue Jul 26, 2024 · 2 comments
Closed
1 of 2 tasks

Card content is hidden behind the tab-bar #289

ymaheshwari1 opened this issue Jul 26, 2024 · 2 comments
Assignees
@Adameddy26
Labels
bug Something isn't working release-v1.9.2

Comments

@ymaheshwari1
Copy link
Contributor

Current behavior

As we have a tab-bar for navigation, the last data on the page is hidden behind the tab.

Expected behavior

Add padding bottom to ion-content, so that all the data is completly visible

Steps to reproduce the issue

Can you handle fixing this bug by yourself?

  • YES
  • NO

Environment details

  • Browser:
  • OS:
  • Code Version:

Additional information

Check this in the whole app and add padding to the bottom wherever required.

image
@ymaheshwari1 ymaheshwari1 added the bug Something isn't working label Jul 26, 2024
@ymaheshwari1 ymaheshwari1 moved this from 📋 Backlog to 📅 Planned in Digital Experience Platform Jul 26, 2024
@ymaheshwari1
Copy link
Contributor Author

ymaheshwari1 commented Jul 26, 2024 •
edited
Loading

@Ridwan6947 Pick this one next.

Ridwan6947 added a commit to Ridwan6947/facilities that referenced this issue Jul 27, 2024
@Ridwan6947
Fixed: Card content is hidden behind the tab-bar (hotwax#289)
435d8b7
@Ridwan6947 Ridwan6947 mentioned this issue Jul 27, 2024
Merged
1 task
Ridwan6947 added a commit to Ridwan6947/facilities that referenced this issue Jul 29, 2024
@Ridwan6947
Fixed: fixed tab-bar alignment and indentataion , removed media queries(
569c2d2 
hotwax#289)
@ymaheshwari1 ymaheshwari1 moved this from 📅 Planned to 👀 In review in Digital Experience Platform Jul 31, 2024
ymaheshwari1 added a commit to ymaheshwari1/facilities that referenced this issue Aug 21, 2024
@ymaheshwari1
Merge branch 'main' into hotwax#289
353b9bf
ymaheshwari1 added a commit to ymaheshwari1/facilities that referenced this issue Aug 21, 2024
@ymaheshwari1
Fixed: styling to have bottom padding to remove the overlapping of co…
2eb1307 
…ntent with tab-bar(hotwax#289)
@ymaheshwari1 ymaheshwari1 mentioned this issue Aug 21, 2024
Merged
1 task
ymaheshwari1 added a commit to ymaheshwari1/facilities that referenced this issue Aug 21, 2024
@ymaheshwari1
Added: padding bottom only when having screen size greater than 991px(h…
3b1bb16 
…otwax#289)
ymaheshwari1 added a commit that referenced this issue Aug 21, 2024
@ymaheshwari1
Merge pull request #298 from ymaheshwari1/#289
d677897 
Fixed: styling to have bottom padding to remove the overlapping of content with tab-bar(#289)
@ymaheshwari1 ymaheshwari1 moved this from 👀 In review to ⏸️ Dev complete in Digital Experience Platform Aug 21, 2024
@Adameddy26 Adameddy26 self-assigned this Aug 27, 2024
@Adameddy26 Adameddy26 moved this from ⏸️ Dev complete to 🛠 In QA in Digital Experience Platform Aug 27, 2024
@Adameddy26
Copy link

Adameddy26 commented Aug 27, 2024 •
edited
Loading

Issue verified and working fine in release v1.9.2. Hence, closing this issue.
Screenshot from 2024-08-27 23-46-54

@github-project-automation github-project-automation bot moved this from 🛠 In QA to ✅ Done in Digital Experience Platform Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Adameddy26 Adameddy26

Labels
bug Something isn't working release-v1.9.2
Projects
Digital Experience Platform
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ymaheshwari1 @Adameddy26