Merge pull request #55 from Nihu-Sharma/#238uwuv

Added slot icon-only to ion-icon in ion-button and updated icon(#238u…
hotwax · Mar 11, 2022 · cfd517f · cfd517f
2 parents e4c5b3f + f10c3a9
commit cfd517f
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 10 deletions.
diff --git a/src/views/AssignPickerModal.vue b/src/views/AssignPickerModal.vue
@@ -3,7 +3,7 @@
     <ion-toolbar>
       <ion-buttons slot="start">
         <ion-button @click="closeModal"> 
-          <ion-icon :icon="closeOutline" />
+          <ion-icon slot="icon-only" :icon="closeOutline" />
         </ion-button>
       </ion-buttons>
       <ion-title>{{ $t("Assign Pickers") }}</ion-title>

diff --git a/src/views/EditPackagingModal.vue b/src/views/EditPackagingModal.vue
@@ -3,7 +3,7 @@
     <ion-toolbar>
       <ion-buttons slot="start">
         <ion-button @click="closeModal"> 
-          <ion-icon :icon="close" />
+          <ion-icon slot="icon-only" :icon="closeOutline" />
         </ion-button>
       </ion-buttons>
       <ion-title>{{ $t("Edit packaging") }}</ion-title>
@@ -104,7 +104,7 @@ import {
   IonToolbar,
   modalController } from "@ionic/vue";
 import { defineComponent } from "vue";
-import { addCircleOutline, close, pricetag } from "ionicons/icons";
+import { addCircleOutline, closeOutline, pricetag } from "ionicons/icons";
 export default defineComponent({
   name: "EditPackagingModal",
   components: { 
@@ -133,7 +133,7 @@ export default defineComponent({
   setup() {
     return {
       addCircleOutline,
-      close,
+      closeOutline,
       pricetag
     };
   },

diff --git a/src/views/ReportIssueModal.vue b/src/views/ReportIssueModal.vue
@@ -3,7 +3,7 @@
     <ion-toolbar>
       <ion-buttons slot="start">
         <ion-button @click="closeModal"> 
-          <ion-icon :icon="close" />
+          <ion-icon slot="icon-only" :icon="closeOutline" />
         </ion-button>
       </ion-buttons>
       <ion-title>{{ $t("Report an issue") }}</ion-title>
@@ -89,7 +89,7 @@ import {
   IonToolbar,
   modalController } from "@ionic/vue";
 import { defineComponent } from "vue";
-import { close, pricetag } from "ionicons/icons";
+import { closeOutline, pricetag } from "ionicons/icons";
 export default defineComponent({
   name: "ReportIssueModal",
   components: { 
@@ -116,7 +116,7 @@ export default defineComponent({
   },
   setup() {
     return {
-      close,
+      closeOutline,
       pricetag
     };
   },

diff --git a/src/views/timezone-modal.vue b/src/views/timezone-modal.vue
@@ -3,7 +3,7 @@
     <ion-toolbar>
       <ion-buttons slot="start">
         <ion-button @click="closeModal"> 
-          <ion-icon :icon="close" />
+          <ion-icon slot="icon-only" :icon="closeOutline" />
         </ion-button>
       </ion-buttons>
       <ion-title>{{ $t("Select time zone") }}</ion-title>
@@ -59,7 +59,7 @@ import {
   modalController,
   alertController } from "@ionic/vue";
 import { defineComponent } from "vue";
-import { close, save } from "ionicons/icons";
+import { closeOutline, save } from "ionicons/icons";
 import { useStore } from "@/store";
 import { UserService } from "@/services/UserService";
 import { hasError } from '@/utils'
@@ -139,7 +139,7 @@ export default defineComponent({
   setup() {
     const store = useStore();
     return {
-      close,
+      closeOutline,
       save,
       store
     };