Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict Marking Orders as Shipped for Tracking-Required Orders #281

Closed
3 tasks
Dhiraj1405 opened this issue Oct 4, 2023 · 0 comments · Fixed by #289 or #337
Closed
3 tasks

Restrict Marking Orders as Shipped for Tracking-Required Orders #281

Dhiraj1405 opened this issue Oct 4, 2023 · 0 comments · Fixed by #289 or #337
Assignees
@alsoK2maan
Labels
enhancement New feature or request

Comments

@Dhiraj1405
Copy link

Dhiraj1405 commented Oct 4, 2023 •
edited
Loading

What is the motivation for adding/enhancing this feature?

Currently, there is a lack of restriction regarding marking orders as shipped for certain shipping methods that require tracking i.e. isTrackingRequired set to Y. This can lead to discrepancies and potential issues with order tracking and customer communication.

Implement a permission where only designated super admin users can mark orders as shipped for tracking-required shipping methods.

What are the acceptance criteria?

  • ...

Can you complete this feature request by yourself?

  • YES
  • NO

Additional information

Ensure that only orders with valid shipping labels are eligible for shipment. Exclude any orders lacking a shipping label; these excluded orders can be manually processed by users with super admin permissions.
@Dhiraj1405 Dhiraj1405 self-assigned this Oct 4, 2023
@Dhiraj1405 Dhiraj1405 added the enhancement New feature or request label Oct 4, 2023
@Dhiraj1405 Dhiraj1405 moved this to 📋 Backlog in Digital Experience Platform Oct 4, 2023
@Dhiraj1405 Dhiraj1405 moved this from 📋 Backlog to 📅 Planned in Digital Experience Platform Oct 4, 2023
@Dhiraj1405 Dhiraj1405 assigned alsoK2maan and unassigned Dhiraj1405 Oct 5, 2023
@alsoK2maan alsoK2maan moved this from 📅 Planned to 🏗 In progress in Digital Experience Platform Oct 5, 2023
alsoK2maan pushed a commit to alsoK2maan/fulfillment-pwa that referenced this issue Oct 5, 2023
@k2maan
Implemented: common admin permission on ship now button if any shipme…
9001e2a 
…nt package require tracking (hotwax#281)
@alsoK2maan alsoK2maan mentioned this issue Oct 5, 2023
Merged
1 task
@alsoK2maan alsoK2maan moved this from 🏗 In progress to 👀 In review in Digital Experience Platform Oct 5, 2023
@alsoK2maan alsoK2maan moved this from 👀 In review to 🏗 In progress in Digital Experience Platform Oct 9, 2023
alsoK2maan pushed a commit to alsoK2maan/fulfillment-pwa that referenced this issue Oct 9, 2023
@k2maan
Implemented: permission on bulk ship button and honoured tracking req…
25e2d67 
…uired condition (hotwax#281)
alsoK2maan pushed a commit to alsoK2maan/fulfillment-pwa that referenced this issue Oct 9, 2023
@k2maan
Improved: removed comment (hotwax#281)
fdf58d1
@alsoK2maan alsoK2maan moved this from 🏗 In progress to 👀 In review in Digital Experience Platform Oct 9, 2023
alsoK2maan pushed a commit to alsoK2maan/fulfillment-pwa that referenced this issue Oct 16, 2023
@k2maan
Improved: permission and variable naming (hotwax#281)
71f6c62
alsoK2maan pushed a commit to alsoK2maan/fulfillment-pwa that referenced this issue Oct 17, 2023
@k2maan
Merge branch 'main' of https://github.com/hotwax/fulfillment-pwa into…
d0f4518 
… fulfillment-pwa/hotwax#281
alsoK2maan pushed a commit to alsoK2maan/fulfillment-pwa that referenced this issue Oct 17, 2023
@k2maan
Improved: logic to exclude tracking required and missing label orders (…
0515ff0 
…hotwax#281)
alsoK2maan pushed a commit to alsoK2maan/fulfillment-pwa that referenced this issue Oct 17, 2023
@k2maan
Improved: experience by adding toast messages if tracking is required…
74ae56b 
… for some or all orders (hotwax#281)
ymaheshwari1 added a commit to ymaheshwari1/fulfillment that referenced this issue Oct 30, 2023
@ymaheshwari1
Improved: condition for bulk ship button on completed page(hotwax#281)
68a51e0
@ymaheshwari1 ymaheshwari1 mentioned this issue Oct 30, 2023
Merged
1 task
ymaheshwari1 added a commit to ymaheshwari1/fulfillment that referenced this issue Oct 30, 2023
@ymaheshwari1
Improved: component name for completed page(hotwax#281)
c5cc27c
ymaheshwari1 added a commit to ymaheshwari1/fulfillment that referenced this issue Oct 30, 2023
@ymaheshwari1
Improved: condition to disable ship now button by honoring missingLab…
dfc40b7 
…elImage check as well(hotwax#281)
ymaheshwari1 added a commit to ymaheshwari1/fulfillment that referenced this issue Oct 30, 2023
@ymaheshwari1
Merge branch 'main' into fulfillment-pwa/hotwax#281
4e95351
ymaheshwari1 added a commit to ymaheshwari1/fulfillment that referenced this issue Oct 30, 2023
@ymaheshwari1
Improved: code to use predefined method for conditions(hotwax#281)
e909a4c
ravilodhi added a commit that referenced this issue Oct 30, 2023
@ravilodhi
Merge pull request #337 from ymaheshwari1/fulfillment-pwa/#281
11315ec 
Implemented: common admin permission on ship now button if any shipment package require tracking (#281)
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Digital Experience Platform Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alsoK2maan alsoK2maan

Labels
enhancement New feature or request
Projects
Digital Experience Platform
Archived in project
Milestone
No milestone
2 participants
@alsoK2maan @Dhiraj1405