Added support to configure date time format from settings page and updated UI of settings page(#2t2y3qq) #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on login(#2t2y3qq)
…nd display in dateTime modal(#2t2y3qq)
disha1202
changed the title
ymaheshwari1
requested changes
Sep 19, 2022
disha1202
changed the title
dt2patel
requested changes
Sep 19, 2022
ymaheshwari1
requested changes
Sep 19, 2022
ymaheshwari1
requested changes
Sep 19, 2022
ymaheshwari1
requested changes
Oct 27, 2022
ymaheshwari1
requested changes
Oct 27, 2022
…ormat in case format mismatch(#2t2y3qq)
ymaheshwari1
requested changes
Oct 28, 2022
ymaheshwari1
approved these changes
Oct 28, 2022
dt2patel
approved these changes
Oct 29, 2022
adityasharma7
suggested changes
Nov 9, 2022
src/store/modules/user/UserState.ts
Outdated
| @@ -3,4 +3,5 @@ export default interface UserState { | |||
| current: object | null; | |||
| currentFacility: object; | |||
| instanceUrl: string; | |||
| dateTimeFormat: string; | |||
There was a problem hiding this comment.
Suggested change
| dateTimeFormat: string; | |
| preferredDateTimeFormat: string; |
There was a problem hiding this comment.
Updated variable name.
src/store/modules/user/actions.ts
Outdated
| @@ -18,6 +18,7 @@ const actions: ActionTree<UserState, RootState> = { | |||
| const resp = await UserService.login(username, password) | |||
| if (resp.status === 200 && resp.data) { | |||
| if (resp.data.token) { | |||
| dispatch('setDateTimeFormat', process.env.VUE_APP_DATE_FORMAT ? process.env.VUE_APP_DATE_FORMAT : 'MM/dd/yyyy'); | |||
There was a problem hiding this comment.
This is should be done after successful login only, after permission check
There was a problem hiding this comment.
Made the requested change.
src/views/OrderDetail.vue
Outdated
| @@ -212,6 +213,10 @@ export default defineComponent({ | |||
| this.fetchFacilities(); | |||
| }, | |||
| methods: { | |||
| isDateInvalid(){ | |||
| // Checked if any of the date format is different than the selected format. | |||
| return !this.ordersList.items.some((item: any) => DateTime.fromFormat(item.arrivalDate, this.dateTimeFormat).isValid); | |||
There was a problem hiding this comment.
I think the condition should be inverted while checking items, if any one of the item is invalid it should return
Suggested change
| return !this.ordersList.items.some((item: any) => DateTime.fromFormat(item.arrivalDate, this.dateTimeFormat).isValid); | |
| return this.ordersList.items.some((item: any) => !DateTime.fromFormat(item.arrivalDate, this.dateTimeFormat).isValid); |
There was a problem hiding this comment.
Made the requested change.
adityasharma7
approved these changes
Nov 15, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #87