Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to view actual QOH on detail page #169

Closed
dt2patel opened this issue Apr 11, 2023 · 11 comments · Fixed by #179
Closed

Option to view actual QOH on detail page #169

dt2patel opened this issue Apr 11, 2023 · 11 comments · Fixed by #179
Assignees

Comments

@dt2patel
Copy link
Contributor

dt2patel commented Apr 11, 2023

What is the motivation for adding/enhancing this feature?

There should be a product store setting that lets companies choose if they want to show systemic QOH on their cycle count product detail page to help users during their count.

This setting should be blocked unless the user has FULFILL_INVCUNT_ADMIN or INV_COUNT_ADMIN

@appurvajain please make draft Product Store Setting data for this and add it here as a comment, I will review.

@Dhiraj1405 make a mockup for this referencing the latest cycle count detail page and also make a setting for it on the settings page.

@Dhiraj1405
Copy link
Contributor

Sure, will add the mockup here in sometime.

@appurvajain
Copy link

appurvajain commented Apr 13, 2023 via email

@appurvajain
Copy link

appurvajain commented Apr 13, 2023

<Enumeration enumId=“QOH_INV_COUNTAPP” enumName=“QOH in Inventory Count app“ enumTypeId="PROD_STR_STNG"/>

@dt2patel
Copy link
Contributor Author

dt2patel commented Apr 13, 2023

@appurvajain

Enum ID: INV_CNT_VIEW_QOH

Enum ID like this allows all inventory count related settings to be identified together more easily since it's in a prefix. The word "view" gives a clear understanding of what verb we're allowing.

enumName: View QOH while inventory counting"
enumDesc: Please come up with a good enum description

@appurvajain
Copy link

@dt2patel

enumDesc: Allows the user to see current QOH from HotWax OMS on the product detail page of the Inventory Count app to help users during the periodic cycle count.

@Dhiraj1405
Copy link
Contributor

Dhiraj1405 commented Apr 17, 2023

Updated files after design tweaks

Count page:

Count with QOH

Upload page:

Upload with QOH

Remove item popover:

Basic

@Dhiraj1405
Copy link
Contributor

Setting Card:
Settings_ Quantity on hand

@dt2patel
Copy link
Contributor Author

I tweaked the designs slightly on your Figma file, but other than that I think we're good to go

@dt2patel
Copy link
Contributor Author

@appurvajain please paste the final enum id here and also commit it to OMS upgrade data

@dt2patel dt2patel moved this to 📋 Backlog in Digital Experience Platform Apr 25, 2023
@dt2patel dt2patel assigned adityasharma7 and unassigned alsoK2maan Apr 26, 2023
@dt2patel dt2patel moved this from 📋 Backlog to 📅 Planned in Digital Experience Platform Apr 26, 2023
@dt2patel
Copy link
Contributor Author

dt2patel commented May 8, 2023

@adityasharma7 this issue is all set to start dev work I think, let me know if we have any blockers here

adityasharma7 added a commit that referenced this issue May 15, 2023
Admin user will have option to allow/disallow viewing current QOH
adityasharma7 added a commit that referenced this issue May 15, 2023
Implemented: Option to view actual QOH on detail page (#169)
@github-project-automation github-project-automation bot moved this from 📅 Planned to ✅ Done in Digital Experience Platform May 15, 2023
@appurvajain
Copy link

appurvajain commented Jun 9, 2023

The final enum data and product store setting data

Enumeration enumId="INV_CNT_VIEW_QOH" enumName="View QOH while inventory counting" enumTypeId="PROD_STR_STNG"/>

ProductStoreSetting fromDate="2022-04-15 00:00:00.0" productStoreId="STORE" settingTypeEnumId="INV_CNT_VIEW_QOH" settingValue=""/>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants