Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add permission check to direct variance log #176

Closed
dt2patel opened this issue Apr 21, 2023 · 0 comments · Fixed by #177
Closed

Add permission check to direct variance log #176

dt2patel opened this issue Apr 21, 2023 · 0 comments · Fixed by #177
Assignees
@adityasharma7

Comments

@dt2patel
Copy link
Contributor

What is the motivation for adding/enhancing this feature?

When users log variance directly from the app there is no approval process, and there is no permission restriction on who can access this screen.

What are the acceptance criteria?

The variance segment on the product detail page should have a permission check where only users with FULFILL_INVCUNT_ADMIN or INV_COUNT_ADMIN can use it.
@dt2patel dt2patel moved this to 📅 Planned in Digital Experience Platform Apr 21, 2023
adityasharma7 added a commit that referenced this issue Apr 27, 2023
@adityasharma7
Implemented: logic to identify authorisations for the given user (#176)
b8f2a61
adityasharma7 added a commit that referenced this issue May 1, 2023
@adityasharma7
Improved: added rules, and added permission checks based upon that (#176
22ef180 
)
adityasharma7 added a commit that referenced this issue May 1, 2023
@adityasharma7
Improved: added permission checks to tab bar routes (#176)
a7632e3
@adityasharma7 adityasharma7 mentioned this issue May 1, 2023
Merged
1 task
adityasharma7 added a commit that referenced this issue May 1, 2023
@adityasharma7
Merge pull request #177 from hotwax/#176
c6fe759 
Implemented: logic to identify authorisations for the given user (#176)
@github-project-automation github-project-automation bot moved this from 📅 Planned to ✅ Done in Digital Experience Platform May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adityasharma7 adityasharma7

Labels
None yet
Projects
Digital Experience Platform
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implemented: logic to identify authorisations for the given user (#176) hotwax/inventory-count
2 participants
@adityasharma7 @dt2patel