Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved: Added Toast Notification on Item Removal from Upload Page(#213) #224

Merged
merged 5 commits into from
Jan 3, 2024
Merged

Improved: Added Toast Notification on Item Removal from Upload Page(#213) #224

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2dce920
Improved: Added Toast Notification on Item Removal from Upload Page(#…
shanmukhdutt Dec 6, 2023
f321d13
Improved: Toast Notifications in upload page
shanmukhdutt Dec 20, 2023
e89f3f8
Fixed: Indentation
shanmukhdutt Dec 20, 2023
b975dac
Improved the notification in upload page
shanmukhdutt Dec 27, 2023
5bfacfc
Implemented the suggested changes
shanmukhdutt Jan 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/locales/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
"inventory variance": "inventory variance",
"Instance Url": "Instance Url",
"Item added to upload list": "Item added to upload list",
"Item removed successfully":"Item removed successfully",
ymaheshwari1 marked this conversation as resolved.
Show resolved Hide resolved
"Loading": "Loading",
"Location": "Location",
"Log variance": "Log variance",
Expand Down
4 changes: 3 additions & 1 deletion src/views/Upload.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,8 @@ import { colorPaletteOutline, resize, cloudUploadOutline } from 'ionicons/icons'
import { mapGetters, useStore } from 'vuex';
import { useRouter } from 'vue-router';
import { ShopifyImg } from '@hotwax/dxp-components';
import { Actions, hasPermission } from '@/authorization'
import { Actions, hasPermission } from '@/authorization';
import { showToast } from '@/utils';

export default defineComponent({
name: "Upload",
Expand Down Expand Up @@ -103,6 +104,7 @@ export default defineComponent({
methods: {
removeItem (sku: any) {
this.store.dispatch('product/removeItemFromUploadProducts', sku)
showToast(this.$t("Item removed from upload list"));
},
async presentAlertOnUpload() {
const alert = await alertController.create({
Expand Down
Loading