Fixed: both the item change buttons becomes active after changing tab(#442) #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we are using indexOf method for finding the product index, but if we already have a current product set, then in that case the product from state is used for finging the index from the filteredItems list, but as the object do not have a common reference, so in this case it always return -1, resulting in buttons being in wrong state. Improved code to find the selected current product first in the filtered items list and then finding its index, so that it has a common reference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
#442
Short Description and Why It's Useful
As we are using indexOf method for finding the product index, but if we already have a current product set, then in that case the product from state is used for finding the index from the filteredItems list, but as the object do not have a common reference, so in this case it always return -1, resulting in buttons being in wrong state.
Improved code to find the selected current product first in the filtered items list and then finding its index, so that it has a common reference.
Screenshots of Visual Changes before/after (If There Are Any)
Before:
Both the buttons are active, even when its the first product.
Contribution and Currently Important Rules Acceptance