Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete getPaidTransactionsAndCreateOrderPayment service from the Job Manager #448

Closed
3 tasks
appurvajain opened this issue Apr 19, 2023 · 6 comments · Fixed by #461
Closed
3 tasks

Delete getPaidTransactionsAndCreateOrderPayment service from the Job Manager #448

appurvajain opened this issue Apr 19, 2023 · 6 comments · Fixed by #461
Assignees
@SandeepRajput20

Comments

@appurvajain
Copy link

What is the motivation for adding/enhancing this feature?

Delete getPaidTransactionsAndCreateOrderPayment service which is visible as payment status on the orders page from the Job Manager

What are the acceptance criteria?

  • ...

Can you complete this feature request by yourself?

  • YES
  • NO

Additional information
@dt2patel
Copy link
Contributor

Does this service not work? What’s wrong with it? Or do we get this through order updates now?

@appurvajain
Copy link
Author

This service cannot be run from the Job Manager as it is a async service and requires parametre whenever run. We need to give order ID which we cannot do from the Job Manager.

Discussed this with Deepak sir as well.

@SandeepRajput20
Copy link
Contributor

I would like to work on this issue.

@ymaheshwari1
Copy link
Contributor

I would like to work on this issue.

Sure, go ahead.

SandeepRajput20 added a commit to SandeepRajput20/job-manager that referenced this issue Apr 28, 2023
@SandeepRajput20
Removed: Payment status job (getPaidTransactionsAndCreateOrderPayment…
aa7a2f9 
… service) from the Job Manager orders page (job-manager/hotwax#448)
@SandeepRajput20 SandeepRajput20 mentioned this issue Apr 28, 2023
Merged
1 task
@adityasharma7
Copy link
Contributor

Does this service not work? What’s wrong with it? Or do we get this through order updates now?

@dt2patel
As mentioned by @appurvajain, the service works for a single order and is used internally. We have a webhook that takes care of it. Should I move ahead with merging the PR?

@dt2patel
Copy link
Contributor

Sure @adityasharma7 thanks for the clarification

adityasharma7 added a commit that referenced this issue May 1, 2023
@adityasharma7
Merge pull request #461 from SandeepRajput20/job-manager/#448
b3a7a25 
Removed: Payment status job (getPaidTransactionsAndCreateOrderPayment service) from the Job Manager orders page (job-manager/#448)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SandeepRajput20 SandeepRajput20

Labels
None yet
Projects
Digital Experience Platform
Archived in project
Milestone
No milestone
5 participants
@adityasharma7 @ymaheshwari1 @dt2patel @SandeepRajput20 @appurvajain