Improved: runTime set to start of the day for 'EVERYDAY' frequency else current time (#2ftb2vw) #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt time according to job frequency
…nt time according to job frequency(#2ftb2vw)
adityasharma7
suggested changes
Jun 20, 2022
src/utils/index.ts
Outdated
| @@ -131,4 +131,9 @@ const handleDateTimeInput = (dateTimeValue: any) => { | |||
| return DateTime.fromISO(dateTime).toMillis() | |||
| } | |||
|
|
|||
| export { handleDateTimeInput, showToast, hasError , parseCsv , jsonToCsv, JsonToCsvOption, isFutureDate } | |||
| const updateRuntime = (job: any) => { | |||
There was a problem hiding this comment.
I think we should return the applicable runtime and calling method should decide setting it.
Suggested change
| const updateRuntime = (job: any) => { | |
| const prepareRuntime = (job: any) => { |
There was a problem hiding this comment.
Updated sir
rathoreprashant
changed the title
ymaheshwari1
approved these changes
Jun 29, 2022
adityasharma7
changed the title
adityasharma7
changed the title
adityasharma7
approved these changes
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes #
Short Description and Why It's Useful
Implemented: update runtime method to set the start of the day & current time according to job frequency
If job frequency is 'EVERYDAY' it will set start of the day else current time
Screenshots of Visual Changes before/after (If There Are Any)
IMPORTANT NOTICE - Remember to add changelog entry
Contribution and Currently Important Rules Acceptance