Implemented functionality to save auto cancel days(#2cxr1cx) #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make a service (updateProductStore) and add a save button to the UI to save changes when user updates auto cancel days settings.
…r handling (#2cxr1cx) used perform find to get the auto cancel days and added toast when auto cancel days are updated
…nt ecom store(#2cxr1cx)
adityasharma7
suggested changes
Aug 17, 2022
src/views/Orders.vue
Outdated
| @@ -274,6 +280,26 @@ export default defineComponent({ | |||
| await this.store.dispatch('webhook/unsubscribeWebhook', { webhookId: webhook?.id, shopifyConfigId: this.shopifyConfigId }) | |||
| } | |||
| }, | |||
| async updateAutoCancelDays(){ | |||
| if(this.autoCancelDays != this.updatedAutoCancelDays){ | |||
There was a problem hiding this comment.
I think we should check if selected product store is not the None while setting and getting
There was a problem hiding this comment.
Made the requested change.
adityasharma7
suggested changes
Aug 18, 2022
src/views/Orders.vue
Outdated
| isDesktop: isPlatform('desktop') | ||
| isDesktop: isPlatform('desktop'), | ||
| autoCancelDays: '', | ||
| updatedAutoCancelDays: '' |
There was a problem hiding this comment.
I think we could have variable names as autoCancelDays and currentAutoCancelDays. Also, instead of checking in update method we should either disable the save button if both the values are same
There was a problem hiding this comment.
Made the requested change.
src/views/Orders.vue
Outdated
| } | ||
| } | ||
| } else { | ||
| showToast(translate('None product store selected.')); |
There was a problem hiding this comment.
Suggested change
| showToast(translate('None product store selected.')); | |
| showToast(translate('Unable to update auto cancel days. None product store selected.')); |
There was a problem hiding this comment.
Updated toast message.
src/views/Orders.vue
Outdated
| showToast(translate("Auto cancel days updated")); | ||
| this.autoCancelDays = this.updatedAutoCancelDays; | ||
| } else { | ||
| showToast(translate("Unable to edit auto cancel days")); |
There was a problem hiding this comment.
Suggested change
| showToast(translate("Unable to edit auto cancel days")); | |
| showToast(translate("Unable to update auto cancel days")); |
There was a problem hiding this comment.
Updated toast message.
…days is not changed(#2cxr1cx)
ymaheshwari1
requested changes
Aug 19, 2022
ymaheshwari1
requested changes
Aug 19, 2022
1 task
adityasharma7
approved these changes
Aug 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes #
Short Description and Why It's Useful
Screenshots of Visual Changes before/after (If There Are Any)
IMPORTANT NOTICE - Remember to add changelog entry
Contribution and Currently Important Rules Acceptance