Fixed: Not able to open job update section on Pipeline page for some jobs (#2rht6hk) #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…jobs (#2rht6hk) Handled case when freq type is not available in environment file. Set default freq type if doesn't exist .env Additional fixes: Missing description when navigating from pipeline to Job Configuration. description field missing in field list while fetching pending jobs When updating the frequency it is not reflecting on Job Configuration component, current is updated but jobStatus is not updated. Used updated lifecycle hook to reintialise the value When skip or cancel job is done for pending jobs, UI flicker occurs. Current is updated whenever skip/cancel action is performed. It should be done only when JobConfiguration component is open and current has some value. Added check to check current before fetching and updating the job. Removed some redundant code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handled case when freq type is not available in environment file. Set default freq type if doesn't exist .env
Additional fixes:
Missing description when navigating from pipeline to Job Configuration. description field missing in field list while fetching pending jobs
When updating the frequency it is not reflecting on Job Configuration component, current is updated but jobStatus is not updated. Used updated lifecycle hook to reintialise the value
When skip or cancel job is done for pending jobs, UI flicker occurs. Current is updated whenever skip/cancel action is performed. It should be done only when JobConfiguration component is open and current has some value. Added check to check current before fetching and updating the job.
Removed some redundant code
Related Issues
Closes https://app.clickup.com/t/2rht6hk
Short Description and Why It's Useful
Screenshots of Visual Changes before/after (If There Are Any)
IMPORTANT NOTICE - Remember to add changelog entry
Contribution and Currently Important Rules Acceptance