Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added shop selector to menu footer(#2a7ymj3) #243

Merged
merged 20 commits into from
Dec 6, 2022
Merged

Added shop selector to menu footer(#2a7ymj3) #243

merged 20 commits into from
Dec 6, 2022

Conversation

disha1202
Copy link
Contributor

@disha1202 disha1202 commented Sep 27, 2022 •
edited
Loading

Related Issues

Closes #129

Short Description and Why It's Useful

Screenshots of Visual Changes before/after (If There Are Any)

IMPORTANT NOTICE - Remember to add changelog entry

Contribution and Currently Important Rules Acceptance

Mayank909 and others added 19 commits May 10, 2022 20:04
@Mayank909
Add shop selector to menu footer(#2a7ymj3)
94fb58e
@Mayank909
Implemented: On shop selection update the jobs on Pipeline.vue(#2a7ymj3)
e02e479
@Mayank909
Improved: changed the position of emitter.off subscriber in pipeline.…
973e3cf 
…vue(#2a7ymj3)
@Mayank909
Remove console.log from the refreshJobs function(#2a7ymj3)
9b96946
@Mayank909
Implemented: menu footerselection change the jobs details in all page…
8df5946 
…s(#2a7ymj3)
@Mayank909
Implemented: call fetchJobs method when component is mounted(#2a7ymj3)
60e4a02
@Mayank909
Changed: suggested naming conventions of variable(#2a7ymj3)
c173227
@Mayank909
Merge branch 'main' of https://github.com/hotwax/job-manager into #2a…
7fd343d 
…7ymj3
@Mayank909
Merge branch 'main' of https://github.com/hotwax/job-manager into #2a…
77df679 
…7ymj3
@Mayank909
Improved: code by removing unwanted changes(#2a7ymj3)
39bdbc4
@Mayank909
Improved: code by removing unwanted console satements(#2a7ymj3)
220ee76
@Mayank909
Improved: code sytex and naming conventions(#2a7ymj3)
8099cc7
@Mayank909
Merge branch 'main' of https://github.com/hotwax/job-manager into #2a…
102dc74 
…7ymj3
@Mayank909
Merge branch 'main' of https://github.com/hotwax/job-manager into #2a…
1ee9478 
…7ymj3
@Mayank909
Fixed: Retry button spinner is moving on store changed(#2a7ymj3)
50cf09a
@Mayank909
Removed: unwanted changes(#2a7ymj3)
7ec6cf5
@disha1202
Merge branch 'main' of https://github.com/hotwax/job-manager into #2a…
e85443a 
…7ymj3
@disha1202
Reverted unwanted changes(#2a7ymj3)
e635e8c
@disha1202
Added a null check and reverted unwanted code(#2a7ymj3)
ceda856
ymaheshwari1
ymaheshwari1 requested changes Oct 7, 2022
View reviewed changes
src/components/Menu.vue Outdated Show resolved Hide resolved
src/views/Pipeline.vue Outdated Show resolved Hide resolved
@disha1202
Improved code to emit product store change if user profile is not und…
12e477e 
…efined and passes event instead of undefined on refresh job(#2a7ymj3)
@alsoK2maan
Copy link
Contributor

alsoK2maan commented Nov 17, 2022 •
edited
Loading

  • Removed if(event) event.target.complete(); from refreshJobs functions on Pipeline and Misc pages.
  • Since we are using ion-button to call the refreshJobs function, event.target.complete(); isn't required.

@adityasharma7 adityasharma7 merged commit 12e477e into hotwax:main Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ymaheshwari1 ymaheshwari1 ymaheshwari1 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add shop selector to menu footer
5 participants
@disha1202 @alsoK2maan @ymaheshwari1 @adityasharma7 @Mayank909