Implemented: Validation to set only future date and time on setting job runtime. (#2tzb5w4) #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ning twice (#2tzb5w4)
ymaheshwari1
requested changes
Oct 28, 2022
ymaheshwari1
approved these changes
Nov 1, 2022
adityasharma7
approved these changes
Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes #264
Short Description and Why It's Useful
Implemented validation when the user sets runtime to accept only future date and time and shows toast when an invalid, past date and time is given. Removed the use of minDateTime.
Screenshots of Visual Changes before/after (If There Are Any)
Screencast.from.28-10-22.10.39.57.AM.IST.webm
IMPORTANT NOTICE - Remember to add changelog entry
Contribution and Currently Important Rules Acceptance