Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented: Filters on pipeline page (#2uw73h5) #272

Merged
merged 27 commits into from
Nov 8, 2022
Merged

Implemented: Filters on pipeline page (#2uw73h5) #272

merged 27 commits into from
Nov 8, 2022

Conversation

shashwatbangar
Copy link
Contributor

@shashwatbangar shashwatbangar commented Nov 8, 2022 •
edited
Loading

Related Issues

Closes #
#242

Short Description and Why It's Useful

> Implemented filters for status, category, and pinned jobs on pipeline pages.
> Selection of multiple filters and persistence on segment change is also added.
> Aids the job managing process for the app as specific jobs can be easily searched.

Screenshots of Visual Changes before/after (If There Are Any)

Screen.Recording.2022-11-08.at.11.13.09.AM.mov

IMPORTANT NOTICE - Remember to add changelog entry

Contribution and Currently Important Rules Acceptance

k2maan and others added 27 commits October 6, 2022 12:11
@k2maan
Implement filters on pipeline page (#2uw73h5)
6f3d201
@k2maan
Fixed indentation
c3818b8
@k2maan
added improvements and keys in en.json
61d81f1
@alsoK2maan
Merge branch 'main' into #2uw73h5
4769860
@k2maan
Refactored code for applying filters by sticking it to single function
f162076
@k2maan
Merge branch '#2uw73h5' of https://github.com/k2maan/job-manager into…
df3a436 
… #2uw73h5
@k2maan
Refactored code to handle filter selection based on the type passed
36c70f1
@k2maan
Added type variable to handle type change
f54c089
@k2maan
Moved logic for managing filter arrays in actions from Filters page. …
417522a 
…(#2uw73h5)
@k2maan
Added type for function param in handleFilterChange function. (#2uw73h5)
8f21f48
@k2maan
Fixed wrong filter type check in action. (#2uw73h5)
f693517
@k2maan
Removed type and added filter type as a string directly, improved HTM…
30899f3 
…L by adding section tag around category filters (#2uw73h5)
@k2maan
Removed type and added filter type as a string directly (#2uw73h5)
0919882
@k2maan
Improved indentation (#2uw73h5)
e2e76ba
@k2maan
Added proper type in function param (#2uw73h5)
732a3a4
@k2maan
Improved indentation (#2uw73h5)
4a5e56e
@k2maan
Refactored code by changing method names and adding necessary and rem…
fb684a0 
…oving unnecessary code in Filter and Pipeline pages(#2uw73h5)
@k2maan
Refactored getter names and filter update mutation (#2uw73h5)
1fea629
@k2maan
Implemeted job refresh on changing page after applying filters (#2uw7…
e419f6f 
…3h5)
@k2maan
Refactored job refresh on changing page after applying filters; added…
bc886db 
… action to handle the same instead of object.assign method (#2uw73h5)
@adityasharma7
Merge branch 'main' into #2uw73h5
652c976
@k2maan
Refactored by changing function name to applyFilter (#2uw73h5)
a57452c
@k2maan
Merge branch '#2uw73h5' of https://github.com/k2maan/job-manager into…
883d45b 
… #2uw73h5
@k2maan
Fixed pinnedJobs.length error (#2uw73h5)
6edc7bb
@k2maan
Refactored code by adding key-value based mutation of filters and red…
3776312 
…ucing the codebase (#2uw73h5)
@shashwatbangar
Fixed: Indentations in Filters view & fixed how we clear filter in mu…
3e15f95 
…tations(#2uw73h5)
@shashwatbangar
Fixed: Rearranged constants alphabetically(#2uw73h5)
d3af4b2
@adityasharma7 adityasharma7 merged commit d3af4b2 into hotwax:main Nov 8, 2022
R-Sourabh added a commit to R-Sourabh/job-manager that referenced this pull request Mar 13, 2024
@R-Sourabh
Improved:Update oms-api package to latest release(hotwax#272)
5d32578
ymaheshwari1 added a commit that referenced this pull request Mar 15, 2024
@ymaheshwari1
Merge pull request #688 from R-Sourabh/#272-Update-oms-api
c4799ef 
Improved:Updated the oms-api package to resolve login issues encountered when /api is omitted from the complete URL. Additionally, implemented a check in the app to handle direct URL access.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shashwatbangar @adityasharma7 @k2maan @alsoK2maan