Implemented filter icon color update based on the type of filters applied and the segment selected (#2zb6ver) #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pplied and the segment selected (#2zb6ver)
…lied and the segment selected (#2zb6ver)
… any of the filter is applied (#2zb6ver)
…ponent itself instead of getters (#2zb6ver)
ymaheshwari1
approved these changes
Nov 10, 2022
adityasharma7
suggested changes
Nov 10, 2022
src/views/Pipeline.vue
Outdated
| @@ -371,7 +370,14 @@ export default defineComponent({ | |||
| getPinnedJobs: 'user/getPinnedJobs', | |||
| currentJob: 'job/getCurrentJob', | |||
| pipelineFilters: 'job/getPipelineFilters', | |||
| }) | |||
| }), | |||
| updateFilterIcon: function() { | |||
There was a problem hiding this comment.
Suggested change
| updateFilterIcon: function() { | |
| filterIconColor: function() { |
adityasharma7
approved these changes
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes #275
Short Description and Why It's Useful
Changed the color of the filter icon to the secondary color if any filter is applied depending the tab we are at.
Screenshots of Visual Changes before/after (If There Are Any)
Finished status filter applied-
No filters applied-
Pinned job filter applied-
IMPORTANT NOTICE - Remember to add changelog entry
Contribution and Currently Important Rules Acceptance