Implement bulk scheduling (#32j3gu0) #314

alsoK2maan · 2022-12-16T07:33:47Z

Related Issues

Closes #304

Short Description and Why It's Useful

The bulk job scheduler enables scheduling multiple jobs at once. The user can select for which store and for which configs they want to schedule the jobs. It aids in the process of setting up the instance as one can ease the process by scheduling multiple jobs at once instead of manually scheduling like before.

Screenshots of Visual Changes before/after (If There Are Any)

IMPORTANT NOTICE - Remember to add changelog entry

Contribution and Currently Important Rules Acceptance

I read and followed contribution rules

…#32j3gu0)

…e UI for the same (#32j3gu0)

…sed handling (#32j3gu0)

…e (#32j3gu0)

…equency and time (#32j3gu0)

…d updating/replacing all the jobs (#32j3gu0)

src/components/JobConfigurationForBulkScheduler.vue

src/locales/en.json

src/store/modules/job/actions.ts

src/views/BulkEditor.vue

src/views/SelectJobsModal.vue

…dated en.json (#32j3gu0)

src/components/JobConfigurationForBulkScheduler.vue

src/store/modules/job/actions.ts

… added locales in en.json and added message in UI for no jobs found (#32j3gu0)

… #32j3gu0

.env.example

src/components/JobConfigurationForBulkScheduler.vue

…n name and comments (#32j3gu0)

adityasharma7 · 2023-01-04T12:16:06Z

src/store/modules/job/actions.ts

+        job.runtimeData && Object.keys(job.runtimeData).map((key: any) => {
+          if (job.runtimeData[key] === 'null') job.runtimeData[key] = ''
+        })
+        jobParams.push({ ...job.runtimeData, ...params, jobId: job.jobId });


We should not pass the jobId

Updated sir, now passing systemJobEnumId, as discussed.

src/components/JobConfigurationForBulkScheduler.vue

src/views/BulkEditor.vue

adityasharma7 · 2023-01-04T13:08:46Z

src/store/modules/job/actions.ts

+
+    if(freqType) {
+      payload.freqType = freqType;
+      if(freqType === 'slow') showToast(translate("This job has slow frequency type, hence, feasible frequency will be set automatically"))
+    }
+    // TODO: find a better solution instead of hardcoding 'EVERYDAY'
+    payload.setTime = state.bulk.setTime;
+    payload.frequency = (state.bulk.frequency && freqType === 'slow') ? 'EVERYDAY' : state.bulk.frequency;
+    commit(types.JOB_ADDED_TO_BULK, payload);


Suggested change

if(freqType) {

payload.freqType = freqType;

if(freqType === 'slow') showToast(translate("This job has slow frequency type, hence, feasible frequency will be set automatically"))

}

// TODO: find a better solution instead of hardcoding 'EVERYDAY'

payload.setTime = state.bulk.setTime;

payload.frequency = (state.bulk.frequency && freqType === 'slow') ? 'EVERYDAY' : state.bulk.frequency;

commit(types.JOB_ADDED_TO_BULK, payload);

payload.frequency = state.bulk.frequency;

if(freqType) {

payload.freqType = freqType;

if(freqType === 'slow') {

// TODO: find a better solution instead of hardcoding 'EVERYDAY'

payload.frequency = 'EVERYDAY' ;

showToast(translate("This job has slow frequency type, hence, feasible frequency will be set automatically"))

}

}

// TODO: find a better solution instead of hardcoding 'EVERYDAY'

payload.setTime = state.bulk.setTime;

commit(types.JOB_ADDED_TO_BULK, payload);

Sir, the code I wrote takes into account that if the frequency is set globally, then only we override it for jobs with slow freqType (payload.frequency = (state.bulk.frequency && freqType === 'slow') ? 'EVERYDAY' : state.bulk.frequency;).

The suggested changes do not provide this functionality.

adityasharma7 · 2023-01-04T13:10:48Z

src/store/modules/job/actions.ts

+    }
+    // TODO: find a better solution instead of hardcoding 'EVERYDAY'
+    payload.setTime = state.bulk.setTime;
+    payload.frequency = (state.bulk.frequency && freqType === 'slow') ? 'EVERYDAY' : state.bulk.frequency;


We could implement a method that returns the feasible frequency based upon freqType

adityasharma7 · 2023-01-04T13:13:03Z

src/store/modules/job/actions.ts

+    // As of now, the job will get scheduled again even if it is pending
+    const jobParams = [] as any;
+    let failedJobs = 0;
+    payload.shopifyConfigs.map((shopId: string) => {


We could use reduce or could handle the returned object

adityasharma7 · 2023-01-04T13:23:29Z

src/store/modules/job/actions.ts

+        return Promise.reject(resp);
+      }
+    })).then((resps: any) => {
+      resps.some((resp: any) => {


I think this might fail if the request other than first one fails

Yes, sir, updated the code to handle the case when jobs other than the first one fail.

adityasharma7 · 2023-01-04T13:24:28Z

src/store/modules/job/actions.ts

+  setBulkJobData({ commit, state }, payload) {
+    let bulkJobs = JSON.parse(JSON.stringify(state.bulk.jobs));
+    const value = payload.value, type = payload.type;
+    if (payload.global) {


We could have separate actions for bulk and configuration component

…ntime (#32j3gu0)

…r than the first job fails (#32j3gu0)

…d (#32j3gu0)

…map method to create params to send in scheduleJob service which can be improved by using array reduce method, as arrayMap always returns an array whereas reduce can be used to return single element which can be obejct or anything(#32j3gu0)

src/components/JobConfigurationForBulkScheduler.vue

adityasharma7 · 2023-01-17T12:03:08Z

src/store/modules/job/actions.ts

+    const jobParams = [] as any;
+    let failedJobs = 0;
+    payload.shopifyConfigs.map((shopId: string) => {
+      return payload.jobs.reduce((params: any, job: any) => {


We are not using reduce correct way

Updated sir

adityasharma7 · 2023-01-17T12:03:39Z

src/store/modules/job/actions.ts

+      }, {})
+    })
+
+    Promise.allSettled(jobParams.map(async (param: any) => {


We could use async await

Sir, the use of Promise.all will reject the next calls if a previous one fails.

adityasharma7 · 2023-01-17T12:11:27Z

src/store/modules/job/actions.ts

+      const resp: any = await JobService.scheduleJob(param);
+      if(resp.status === 200 && !hasError(resp)){
+        // Removing the scheduled job
+        dispatch('removeBulkJob', param.systemJobEnumId);


We should remove them in bulk

Updated sir

src/store/modules/job/actions.ts

adityasharma7 · 2023-01-17T12:13:36Z

src/store/modules/job/actions.ts

+    // set the maximum slow frequency for slow type jobs if global frequnecy is set
+    payload.frequency = (state.bulk.frequency && freqType === 'slow') ? (generateFrequencyOptions('slow') as any).pop().value : state.bulk.frequency;
+
+    const bulk = JSON.parse(JSON.stringify(state.bulk.jobs));


Suggested change

const bulk = JSON.parse(JSON.stringify(state.bulk.jobs));

const bulkJobs = JSON.parse(JSON.stringify(state.bulk.jobs));

adityasharma7 · 2023-01-17T12:15:19Z

src/store/modules/job/actions.ts

+      if(job.freqType === 'slow') {
+        showToast(translate("Some jobs have slow frequency type, hence, feasible frequency will be set automatically"))
+        // If user sets a valid slow frequency, we honour it else maximum frequency is set
+        const slowFreqs = generateFrequencyOptions('slow').map((obj: any) => obj.value)


We could generate them once and use further

Updated sir

…tead of map (#32j3gu0)

…ency and improved code (#32j3gu0)

… #32j3gu0

…ulkScheduler (#32j3gu0)

k2maan added 11 commits December 16, 2022 12:55

Implemented UI for product store and shopify config (#32j3gu0)

94b20c2

Implemented SelectJobsModal for fetching jobs to schedule (#32j3gu0)

f32a2ab

Implemented job fetching based on user's store and config selection (…

63f7475

…#32j3gu0)

Implemented job selection logic and UI (#32j3gu0)

7d90a4b

Implemented bulk scheduling for draft all jobs at once (#32j3gu0)

6214051

Implemented scheduling for specific time and frequency and updated th…

a9842cc

…e UI for the same (#32j3gu0)

Refactored code (#32j3gu0)

8f4d712

Refactored code (#32j3gu0)

c938f80

Fixed wrong job runtime issue (#32j3gu0)

0b51275

Implemented scheduling for multiple shopifyConfigs through promise ba…

5a57000

…sed handling (#32j3gu0)

Implemented disabling of fab button when no jobs are there to schedul…

062f08b

…e (#32j3gu0)

alsoK2maan requested a review from adityasharma7 December 21, 2022 11:50

alsoK2maan marked this pull request as ready for review December 21, 2022 11:52

alsoK2maan and others added 5 commits December 21, 2022 17:23

Merge branch 'main' into #32j3gu0

064bc3b

Refactored code and implemented single action for setting bulk job fr…

f4c4936

…equency and time (#32j3gu0)

Resolving merge conflicts

e6f50a5

Removed commented code (#32j3gu0)

4285819

Refactored code and implemented seperate mutations for adding jobs an…

a211ea8

…d updating/replacing all the jobs (#32j3gu0)

ymaheshwari1 requested changes Dec 22, 2022

View reviewed changes

k2maan added 4 commits December 22, 2022 19:12

Refactored code; changed mutations names, variables, functions and up…

cca1812

…dated en.json (#32j3gu0)

Implemented option to remove selected jobs (#32j3gu0)

2094d55

Added toast to show number of failed jobs (#32j3gu0)

482699d

Refactored code for showing shopifyConfig names for job cards (#32j3gu0)

99529b2

alsoK2maan requested a review from ymaheshwari1 December 27, 2022 05:12

Implemented toast when no jobs are found (#32j3gu0)

6b26a1e

ymaheshwari1 requested changes Dec 28, 2022

View reviewed changes

k2maan added 3 commits December 29, 2022 16:46

Implemented default global frequency setting for slow frequency jobs,…

e73797d

… added locales in en.json and added message in UI for no jobs found (#32j3gu0)

Implemented default global frequency setting for slow frequency jobs,…

615a0a0

… added locales in en.json and added message in UI for no jobs found (#32j3gu0)

Merge branch '#32j3gu0' of https://github.com/k2maan/job-manager into…

2fb8783

… #32j3gu0

ymaheshwari1 requested changes Dec 29, 2022

View reviewed changes

.env.example Outdated Show resolved Hide resolved

k2maan added 2 commits December 30, 2022 12:57

Implemented code to clear bulk data on logout (#32j3gu0)

1bd56a5

Refactored code (#32j3gu0)

c14edae

ymaheshwari1 requested changes Dec 30, 2022

View reviewed changes

src/components/JobConfigurationForBulkScheduler.vue Outdated Show resolved Hide resolved

k2maan added 2 commits December 30, 2022 15:50

Implemented utility method for frequency options and improved functio…

1d9559a

…n name and comments (#32j3gu0)

Refactored code and improved generateFrequencyOptions method (#32j3gu0)

6b7bf0b

ymaheshwari1 approved these changes Dec 30, 2022

View reviewed changes

adityasharma7 suggested changes Jan 4, 2023

View reviewed changes

k2maan and others added 7 commits January 5, 2023 12:37

Improved naming and code readability (#32j3gu0)

12444c6

Refactored code and implemented seperate actions for frequency and ru…

f39b842

…ntime (#32j3gu0)

Refactored scheduleBulkJobs action to handle condition when jobs othe…

35c7b97

…r than the first job fails (#32j3gu0)

Refactored removeBulkJob action; used systemJobEnumId instead of jobI…

d3acdec

…d (#32j3gu0)

Merge branch 'main' into #32j3gu0

9ec1859

Updated getShopifyConfig API by enabling caching (#32j3gu0)

fc9ec88

alsoK2maan requested a review from adityasharma7 January 17, 2023 10:51

dt2patel approved these changes Jan 17, 2023

View reviewed changes

dt2patel assigned alsoK2maan Jan 17, 2023

Refactored addToBulkScheduler action (#32j3gu0)

df95b51

adityasharma7 suggested changes Jan 17, 2023

View reviewed changes

k2maan added 2 commits January 18, 2023 11:29

Refactored actions and used reduce in the scheduleBulkJobs action ins…

80625d6

…tead of map (#32j3gu0)

Refactored code; removed commented code (#32j3gu0)

13d0a85

alsoK2maan requested a review from adityasharma7 January 18, 2023 06:04

adityasharma7 and others added 6 commits January 18, 2023 13:08

Merge branch 'main' into #32j3gu0

58b3f93

Refactored actions; improved the use of reduce (#32j3gu0)

a5f3799

Refactored code; implemented seperate mutations for runtime and frequ…

1d0f8f3

…ency and improved code (#32j3gu0)

Merge branch '#32j3gu0' of https://github.com/k2maan/job-manager into…

ea71514

… #32j3gu0

Refactored code by improving variable naming and JobConfigurationForB…

4d669d2

…ulkScheduler (#32j3gu0)

Refactored code by renaming runtime to runTime on job objects (#32j3gu0)

7b9e69a

adityasharma7 approved these changes Jan 18, 2023

View reviewed changes

adityasharma7 merged commit 1197c49 into hotwax:main Jan 18, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement bulk scheduling (#32j3gu0) #314

Implement bulk scheduling (#32j3gu0) #314

alsoK2maan commented Dec 16, 2022 •

edited

Loading

adityasharma7 Jan 4, 2023

alsoK2maan Jan 6, 2023

adityasharma7 Jan 4, 2023

alsoK2maan Jan 5, 2023

adityasharma7 Jan 4, 2023

alsoK2maan Jan 6, 2023

adityasharma7 Jan 4, 2023

alsoK2maan Jan 17, 2023

adityasharma7 Jan 4, 2023

alsoK2maan Jan 6, 2023 •

edited

Loading

adityasharma7 Jan 4, 2023

alsoK2maan Jan 6, 2023

adityasharma7 Jan 17, 2023

alsoK2maan Jan 18, 2023

adityasharma7 Jan 17, 2023

alsoK2maan Jan 18, 2023

adityasharma7 Jan 17, 2023

alsoK2maan Jan 18, 2023

adityasharma7 Jan 17, 2023

alsoK2maan Jan 18, 2023

adityasharma7 Jan 17, 2023

alsoK2maan Jan 18, 2023

	const bulk = JSON.parse(JSON.stringify(state.bulk.jobs));
	const bulkJobs = JSON.parse(JSON.stringify(state.bulk.jobs));

Implement bulk scheduling (#32j3gu0) #314

Implement bulk scheduling (#32j3gu0) #314

Conversation

alsoK2maan commented Dec 16, 2022 • edited Loading

Related Issues

Short Description and Why It's Useful

Screenshots of Visual Changes before/after (If There Are Any)

Contribution and Currently Important Rules Acceptance

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alsoK2maan Jan 6, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alsoK2maan commented Dec 16, 2022 •

edited

Loading

alsoK2maan Jan 6, 2023 •

edited

Loading