Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: alert header issue by always displaying Run now in header and made the message consistent across app(#85zt2zp30) #488

Merged
merged 7 commits into from
May 19, 2023

Conversation

ymaheshwari1
Copy link
Contributor

@ymaheshwari1 ymaheshwari1 commented May 18, 2023

Related Issues

Closes #486

Short Description and Why It's Useful

  • Made the run now alert header and message consistent across app.
  • Updated the header for frequency options to Frequency instead of using dynamic title
  • Removed unused locale entry, and unused title entry from env

Screenshots of Visual Changes before/after (If There Are Any)

Before (run now alert):

image

After (run now alert):

image

Before (frequency options):

image

After (frequency options):

image

IMPORTANT NOTICE - Remember to add changelog entry

Contribution and Currently Important Rules Acceptance

@ymaheshwari1 ymaheshwari1 changed the title Fixed: alert header issue by displaying enumName or jobName for header(#85zt2zp30) Fixed: alert header issue by always displaying Run now in header and made the message consistant across app(#85zt2zp30) May 19, 2023
@ymaheshwari1 ymaheshwari1 changed the title Fixed: alert header issue by always displaying Run now in header and made the message consistant across app(#85zt2zp30) Fixed: alert header issue by always displaying Run now in header and made the message consistent across app(#85zt2zp30) May 19, 2023
@ymaheshwari1 ymaheshwari1 marked this pull request as ready for review May 19, 2023 07:08
@adityasharma7 adityasharma7 merged commit 1d4e036 into hotwax:main May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Header in alert is not visible when using runNow feature
2 participants