Implemented: Updated the DataManager Logs page to be dynamic in Job Manager(#680) #729
Conversation
| <template> | ||
| <ion-content> | ||
| <ion-list> | ||
| <ion-list-header>{{ translate('Log Id') }}</ion-list-header> |
There was a problem hiding this comment.
This will the data manager log ID not the text "Log Id".
| <ion-item button @click="downloadLogFile('logFile')"> | ||
| {{ translate('Log file') }} | ||
| </ion-item> | ||
| <ion-item button :lines="log?.errorRecordContentId ? undefined : 'none'" @click="downloadLogFile('uploadedFle')"> |
There was a problem hiding this comment.
I think we should show error item disabled instead of hiding, if there is not error content.
src/store/modules/job/actions.ts
Outdated
| let logs = [] as any | ||
| const payload = { | ||
| "inputFields": { | ||
| "statusId": ["SERVICE_CANCELLED", "SERVICE_CRASHED", "SERVICE_FAILED", "SERVICE_FINISHED", "SERVICE_PENDING", "SERVICE_RUNNING", "SERVICE_QUEUED"], |
There was a problem hiding this comment.
No need to apply any filter on status.
src/store/modules/job/actions.ts
Outdated
| }).catch((err: any) => { | ||
| logger.error(err); | ||
| }) | ||
| commit(types.JOB_DATA_RESOURCE_IDS_UPDATED, dataResourceIds); |
There was a problem hiding this comment.
Instead of storing dataResourceIds separately, I think you should add the needed field in the respective data manager config record itself.
src/store/modules/job/actions.ts
Outdated
| commit(types.JOB_DATA_RESOURCE_IDS_UPDATED, dataResourceIds); | ||
| }, | ||
|
|
||
| async fetchDataManagerConfig({ commit }, params) { |
There was a problem hiding this comment.
As we are not storing anything to state here, we can skip using action here. Service itself should fulfil the purpose.
src/components/ImportLogsDetail.vue
Outdated
| <p>{{ translate('Finished') }}</p> | ||
| </ion-label> | ||
|
|
||
| <ion-badge color="success" v-if="log.statusId === 'SERVICE_FINISHED'">{{ translate('Finished') }}</ion-badge> |
There was a problem hiding this comment.
Display the status description here. You need to fetch the status data for statusTypeId='SERVICE_STATUS' and then create uiLables for all the statuses.
src/components/ImportLogsDetail.vue
Outdated
| return { | ||
| configDetails: {}, | ||
| selectedChip: 'All', | ||
| chips: [ |
There was a problem hiding this comment.
This should be renamed to logFilters and it should be the array of object, each filter object with key and value. So that when apply filters you can pass the ID.
…e text refactor job actions(hotwax#680)
… and made changes in the css(hotwax#680)
…gs using jobId instead of configId (hotwax#680).
… on customparameter modal(hotwax#680) - added condition to fetch logs only for history segment.
…ding to the history segment (hotwax#680)
… added isDesktop property for history segment(hotwax#680)
…lePopover and parameter type(hotwax#680)
Related Issues
#680
Short Description and Why It's Useful
Screenshots of Visual Changes before/after (If There Are Any)
Contribution and Currently Important Rules Acceptance