Implemented: API calls to get user preferred store and ecom stores in user module #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alsoK2maan
suggested changes
Oct 9, 2023
| } | ||
| } | ||
|
|
||
| async function getEComStores (facilityId: string, token: any, baseURL: string): Promise<Response> { |
There was a problem hiding this comment.
Why are mentioning the returned type as Promise<Response>
| 'Content-Type': 'application/json' | ||
| } | ||
| }); | ||
| if (hasError(resp) || resp.data.docs.length === 0) { |
There was a problem hiding this comment.
This check might not be required resp.data.docs.length === 0
| if (hasError(resp)) { | ||
| return Promise.reject(resp.data) | ||
| } | ||
| return Promise.resolve(resp.data.userPrefValue ? resp.data.userPrefValue : ''); |
There was a problem hiding this comment.
Suggested change
| return Promise.resolve(resp.data.userPrefValue ? resp.data.userPrefValue : ''); | |
| return Promise.resolve(resp.data.userPrefValue); |
|
Closing as handled in #87 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Related - hotwax/dxp-components#193
Short Description and Why It's Useful
Screenshots of Visual Changes before/after (If There Are Any)
Contribution and Currently Important Rules Acceptance