Merge pull request #30 from Yashi002/#1x69mn1

Improve payload preparation for search products(#1x69mn1)
hotwax · Jan 7, 2022 · dc96db5 · dc96db5
2 parents d5d141d + 1b9676c
commit dc96db5
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/changelogs/unreleased/-1x69mn1.yml b/changelogs/unreleased/-1x69mn1.yml
@@ -0,0 +1,6 @@
+---
+title: Improve payload preparation for search products
+ticket_id: "#1x69mn1"
+merge_request: 30
+author: Yashi Verma
+type: changed
diff --git a/src/store/modules/product/actions.ts b/src/store/modules/product/actions.ts
@@ -16,11 +16,12 @@ const actions: ActionTree<ProductState, RootState> = {
   async fetchProducts ( { commit, state }, { productIds }) {
     const cachedProductIds = Object.keys(state.cached);
     const productIdFilter= productIds.reduce((filter: string, productId: any) => {
-      if (filter !== '') filter += ' OR '
       // If product already exist in cached products skip
       if (cachedProductIds.includes(productId)) {
         return filter;
       } else {
+        // checking condition that if the filter is not empty then adding 'OR' to the filter
+        if (filter !== '') filter += ' OR '
         return filter += productId;
       }
     }, '');