Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow users to close purchase orders when they receive them #212

Closed
1 task
Dhiraj1405 opened this issue Apr 9, 2023 · 2 comments · Fixed by #258
Closed
1 task

Allow users to close purchase orders when they receive them #212

Dhiraj1405 opened this issue Apr 9, 2023 · 2 comments · Fixed by #258
Assignees
@amansinghbais
Labels
enhancement New feature or request

Comments

@Dhiraj1405
Copy link
Contributor

What is the motivation for adding/enhancing this feature?

Users can currently only receive inventory for purchase orders; there is no manual control for users to close the PO. When the promise date arrives, the PO automatically expires. Manually closing a PO communicates to the system that the respective PO's inventory has been received and will not be received again.

What are the acceptance criteria?

Only users with order edit permissions can close a purchase order from the Purchase Order detail page.

Can you complete this feature request by yourself?

  • YES
  • NO

Additional information
@Dhiraj1405 Dhiraj1405 changed the title Allow users to select if they want to close the purchase order when receiving it Allow users to decide when they receive a purchase order whether they want to close it. Apr 9, 2023
@Dhiraj1405 Dhiraj1405 changed the title Allow users to decide when they receive a purchase order whether they want to close it. Allow users to close purchase orders when they receive them Apr 9, 2023
@Dhiraj1405 Dhiraj1405 moved this to 📋 Backlog in Digital Experience Platform Apr 9, 2023
@Dhiraj1405 Dhiraj1405 added the enhancement New feature or request label Apr 9, 2023
@dt2patel dt2patel moved this from 📋 Backlog to 📅 Planned in Digital Experience Platform Apr 10, 2023
@adityasharma7
Copy link
Contributor

Assigned to @Nidbhagwat and @Dhiraj1405 for UI inputs

@Nidbhagwat Nidbhagwat moved this from 📅 Planned to 🏗 In progress in Digital Experience Platform May 18, 2023
@Dhiraj1405 Dhiraj1405 moved this from 🏗 In progress to 📅 Planned in Digital Experience Platform Aug 24, 2023
@Dhiraj1405
Copy link
Contributor Author

Please find the UI here: https://www.figma.com/file/bVPRRw282CqGKMdbz7dciH/HC-Ionic-design-system?type=design&node-id=28295%3A91785&mode=design&t=OFlkolqcT8i31VMC-1

@amansinghbais amansinghbais moved this from 📅 Planned to 🏗 In progress in Digital Experience Platform Aug 25, 2023
amansinghbais added a commit to amansinghbais/receiving that referenced this issue Aug 29, 2023
@amansinghbais
Implemented: functionality which allows users to manually close purch…
9df9dfc 
…ase order items when they receive them (hotwax#212)
@amansinghbais amansinghbais mentioned this issue Aug 29, 2023
Merged
1 task
@amansinghbais amansinghbais moved this from 🏗 In progress to 👀 In review in Digital Experience Platform Aug 29, 2023
amansinghbais added a commit to amansinghbais/receiving that referenced this issue Sep 11, 2023
@amansinghbais
Improved: code for closePO's modal (hotwax#212)
50a4221
amansinghbais added a commit to amansinghbais/receiving that referenced this issue Sep 11, 2023
@amansinghbais
Improved: code for close PO items (hotwax#212)
556f7d1
amansinghbais added a commit to amansinghbais/receiving that referenced this issue Sep 18, 2023
@amansinghbais
Merge branch 'main' of https://github.com/hotwax/receiving into recei…
076243a 
…ving/hotwax#212
amansinghbais added a commit to amansinghbais/receiving that referenced this issue Sep 18, 2023
@amansinghbais
Improved: indentation, casing, conditions (hotwax#212)
9770a27
amansinghbais added a commit to amansinghbais/receiving that referenced this issue Sep 20, 2023
@amansinghbais
Improved: conditions which are not required and if syntax (hotwax#212)
75398ef
amansinghbais added a commit to amansinghbais/receiving that referenced this issue Oct 9, 2023
@amansinghbais
Improved: used emitter to call parent component function from modal (h…
3c07e28 
…otwax#212)
@ymaheshwari1 ymaheshwari1 moved this from 👀 In review to 🏗 In progress in Digital Experience Platform Oct 10, 2023
amansinghbais added a commit to amansinghbais/receiving that referenced this issue Oct 11, 2023
@amansinghbais
Improved: logic to call changeOrderItemStatus api and show Toast acco…
09dd51b 
…rdingly (hotwax#212)
@amansinghbais amansinghbais moved this from 🏗 In progress to 👀 In review in Digital Experience Platform Oct 11, 2023
amansinghbais added a commit to amansinghbais/receiving that referenced this issue Oct 12, 2023
@amansinghbais
Improved: better alternative for statusUpdated Variable (hotwax#212)
57fc6b2
@amansinghbais amansinghbais moved this from 👀 In review to 📅 Planned in Digital Experience Platform Oct 16, 2023
amansinghbais added a commit to amansinghbais/receiving that referenced this issue Oct 17, 2023
@amansinghbais
Merge branch 'main' of https://github.com/hotwax/receiving into recei…
59f1e69 
…ving/hotwax#212
amansinghbais added a commit to amansinghbais/receiving that referenced this issue Oct 17, 2023
@amansinghbais
Improved: code to handle newly added items (hotwax#212)
f6ea9d5
@amansinghbais amansinghbais moved this from 📅 Planned to 👀 In review in Digital Experience Platform Oct 17, 2023
amansinghbais added a commit to amansinghbais/receiving that referenced this issue Oct 17, 2023
@amansinghbais
Improved: promise.allsettled response handling (hotwax#212)
9571d70
amansinghbais added a commit to amansinghbais/receiving that referenced this issue Oct 18, 2023
@amansinghbais
Improved: code for handling item selection for status update (hotwax#212
75c5c83 
)
amansinghbais added a commit to amansinghbais/receiving that referenced this issue Oct 18, 2023
@amansinghbais
Fixed: removed comments from the api parameters (hotwax#212)
878850c
amansinghbais added a commit to amansinghbais/receiving that referenced this issue Oct 18, 2023
@amansinghbais
Improved: optimized way of writing conditions (hotwax#212)
ac43b04
amansinghbais added a commit to amansinghbais/receiving that referenced this issue Oct 18, 2023
@amansinghbais
Improved: variable name and comments (hotwax#212)
6cd37f6
ravilodhi added a commit that referenced this issue Oct 20, 2023
@ravilodhi
Merge pull request #258 from amansinghbais/receiving/#212
e90e189 
Implemented: functionality which allows users to manually close purchase order items when they receive them. (#212)
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Digital Experience Platform Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amansinghbais amansinghbais

Labels
enhancement New feature or request
Projects
Digital Experience Platform
Archived in project
Milestone
No milestone
5 participants
@adityasharma7 @Nidbhagwat @sanskar345 @amansinghbais @Dhiraj1405