Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download option visible and blank file downloads for security group with no permissions set. #134

Closed
Adameddy26 opened this issue Feb 29, 2024 · 4 comments · Fixed by #141
Assignees
Labels

Comments

@Adameddy26
Copy link

Adameddy26 commented Feb 29, 2024

Expected behavior

Users belonging to the security group with no permissions should not see the download option for files.

Steps to reproduce the issue

Log in to the App with valid credentials.
Navigate to permissions section and open any security group for which no permissions are set or else create a new group with no permissions.
Observe the presence of a download option associated with the file.
Click on the download option to initiate the download process.
Verify the contents of the downloaded file.

Environment details

App version: MAIN-92E369A
App environment: DEV

Additional information

https://jam.dev/c/17f8c45b-9bd3-45e1-9996-a51ece4c84f9

@Adameddy26 Adameddy26 added the bug Something isn't working label Feb 29, 2024
@Adameddy26 Adameddy26 moved this to 📋 Backlog in Digital Experience Platform Feb 29, 2024
@dt2patel
Copy link
Contributor

The option should still be there and on clicking it user will see an alert asking the user to add permissions to the security group first.

Title: No permissions associated
Description: "No permissions have been linked to this group yet. Permissions for a group cannot be downloaded.
Actions: Dimisss

@dt2patel dt2patel assigned amansinghbais and unassigned ravilodhi Mar 1, 2024
amansinghbais added a commit to amansinghbais/user-management that referenced this issue Mar 4, 2024
@amansinghbais amansinghbais moved this from 📋 Backlog to 👀 In review in Digital Experience Platform Mar 4, 2024
ravilodhi added a commit that referenced this issue Mar 7, 2024
Improved: added an alert in case of downloading csv file for group without any permissions (#134)
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Digital Experience Platform Mar 7, 2024
@Adameddy26
Copy link
Author

Issue verified and working fine in release v1.5.2.
https://jam.dev/c/3e3b7896-d8b8-45d6-bef9-867fed2b65bd

@Adameddy26
Copy link
Author

Users logging into the app without initially selecting a security group encounter an issue where they are unable to download the permissions file for all groups.
Hence, reopening this issue.

@Adameddy26 Adameddy26 reopened this Mar 14, 2024
@Adameddy26 Adameddy26 assigned ravilodhi and unassigned Adameddy26 Mar 14, 2024
@Adameddy26 Adameddy26 moved this from ✅ Done to 📋 Backlog in Digital Experience Platform Mar 14, 2024
amansinghbais added a commit to amansinghbais/user-management that referenced this issue Mar 14, 2024
@amansinghbais amansinghbais moved this from 📋 Backlog to 👀 In review in Digital Experience Platform Mar 14, 2024
ymaheshwari1 added a commit that referenced this issue Mar 19, 2024
Improved: conditions to show alert only if a group is selected and no permission associated (#134)
@Adameddy26 Adameddy26 self-assigned this Mar 26, 2024
@Adameddy26 Adameddy26 moved this from 👀 In review to ✅ Done in Digital Experience Platform Mar 26, 2024
@Adameddy26
Copy link
Author

Issue verified and working fine in release v1.7.0.
https://jam.dev/c/161070c7-7987-43e3-99c0-29d587149c18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
4 participants