Changed install template system call to account for spaces in path #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`path` may contain a space. In the old code this broke the system call.New version is in line with other library install templates (e.g. importmap).
dhh
reviewed
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very small fix to the installation process. In run_stimulus_install_template the path may contain a space. In my case, the bundle directory has a space in it for some reason unknown to me (vendor/bundle /). In the old code this broke the system call and prevented generation of a new rails project by rails new app_name. The new version is in line with other library install templates like importmap)
I'm using rbenv on Arch, ruby 3.3.1, rails 7.1.3.2.