Move dispatch helper from context to controller #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#421 hasn't been merged to main yet, so feel free to get a test added here! |
dhh
added a commit
that referenced
this pull request
Sep 1, 2021
Move dispatch helper from context to controller
dhh
added a commit
that referenced
this pull request
Sep 2, 2021
* Move to a single package that targets ES2017 and ESM only * include tests again * cleanup * reorg `src/tests/` folder * adjustments to build and test setup * Produce UMD format for those still not on ESM It's easy enough to do, so no reason as yet not to. * Use mode recent node * No need for TS on this redirection package * Prepare the redirection package But now I have second thoughts as to whether it's a good idea in any case. * Only include dist packages + types * Update all imports to the new package * Update old reference * Fix yalc reference * Update which files are included in the package * Update copyright dates * build project to es5 to able to run it with karma * Merge pull request #432 from adrienpoly/fix-dispatch Move dispatch helper from context to controller * fix fixtures paths for use with karma * fix `webpack-helpers` test * don't specify karma plugins explictly * freshen karma browser list * Fix yarn lock Co-authored-by: Marco Roth <marco.roth@intergga.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #431
This feature had no tests linked to it, this is only a patch. Once we get the test suite back on track (#421) I can try to add something simple to ensure it remains functional.