Let Session know it needs to reload
#150
Conversation
It is helpful to let other Session instances know that data on the server changed and what they are rendering might be out of date. This is mostly useful when there are tabs.
What about Just chiming in that a potentially less invasive action than reload would be to refresh the session instead, which would keep scroll and state if morphing is enabled. Would love to see a |
|
Not really, I was just suggesting to add a method to This way stale content is updated while preserving scroll and state, if morphing is enabled. |
|
Oh! I didn't catch that distinction. Great point on |
When working with multiple Turbo instances across tabs data can easily become out of sync. Submitting a form on the first tab might change data currently displayed on the second. And signing in on one tab might change everything about the others!
Session.clearSnapshotCache()only works when navigating back to a cached page. It doesn't help if the active screen is being shown on a tab.This PR introduced a new public function,
Session.setNeedsReload(). When the session's underlyingVisitableappears it reloads if this function was called earlier.The name of the function feels a bit off.
clearSnapshotCache()is perfect, it is action-oriented and easy to understand. Is there a similar name forsetNeedsReload()?Alternatively, we ignore Turbo.js's snapshot cache cleaning and always reload the page (when it appears). I don't think that would change much, if any, existing behavior.