Merge pull request #1079 from brunoprietog/use-pathname-for-refreshes

Page refreshes: Use pathname instead of href to detect if locations are equal

src/core/drive/page_view.js

@@ -56,7 +56,7 @@ export class PageView extends View {
   }
 
   isPageRefresh(visit) {
-    return !visit || (this.lastRenderedLocation.href === visit.location.href && visit.action === "replace")
+    return !visit || (this.lastRenderedLocation.pathname === visit.location.pathname && visit.action === "replace")
   }
 
   shouldPreserveScrollPosition(visit) {

src/tests/fixtures/page_refresh.html

@@ -46,6 +46,7 @@ <h2>Frame to be preserved</h2>
       <h3>Element with Stimulus controller</h3>
     </div>
 
+    <p><a id="replace-link" data-turbo-action="replace" href="/src/tests/fixtures/page_refresh.html?param=something">Link with params to refresh the page</a></p>
     <p><a id="link" href="/src/tests/fixtures/one.html">Link to another page</a></p>
 
     <form id="form" action="/__turbo/refresh" method="post" class="redirect">

src/tests/functional/page_refresh_tests.js

@@ -17,6 +17,13 @@ test("renders a page refresh with morphing", async ({ page }) => {
   await nextEventNamed(page, "turbo:render", { renderMethod: "morph" })
 })
 
+test("renders a page refresh with morphing when the paths are the same but search params are diferent", async ({ page }) => {
+  await page.goto("/src/tests/fixtures/page_refresh.html")
+
+  await page.click("#replace-link")
+  await nextEventNamed(page, "turbo:render", { renderMethod: "morph" })
+})
+
 test("doesn't morph when the turbo-refresh-method meta tag is not 'morph'", async ({ page }) => {
   await page.goto("/src/tests/fixtures/page_refresh_replace.html")